FixUserFilePermissions.ps1: use wildcard to get keys#864
Open
sharpchen wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Updates the Windows FixUserFilePermissions.ps1 helper to discover user SSH keys with algorithm-prefixed variants (e.g., id_ed25519_sk*) by expanding the Get-ChildItem -Include patterns.
Changes:
- Switch key discovery from exact filenames (
id_rsa,id_ed25519, …) to wildcard patterns (id_rsa*,id_ed25519*, …) to cover algorithm-prefixed variants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+15
| Get-ChildItem ~\.ssh\* -File -Include "id_rsa*","id_dsa*","id_ecdsa*","id_ed25519*" -ErrorAction SilentlyContinue | | ||
| Where-Object Extension -eq '' | | ||
| ForEach-Object { |
Author
There was a problem hiding this comment.
Might have *.bak as well, would you like to include them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Use wildcard pattern for
-IncludePR Context
ssh keys can have arbitrary names, using algorithm name as prefix should be a common and good practice.
Currently it only matches on exact name, use wildcard to include those with prefixes.