Convert ESLint config and add Prettier

Author: andyleejordan

.editorconfig

@@ -5,6 +5,7 @@ charset = utf-8
 indent_style = space
 indent_size = 4
 insert_final_newline = true
+trim_trailing_whitespace = true
 
 [*.{json,yaml,yml,code-workspace}]
 indent_size = 2

.eslintrc.json

@@ -0,0 +1,3 @@
+dist/
+modules/
+out/

.prettierignore

@@ -0,0 +1,48 @@
+import eslint from "@eslint/js";
+import eslintConfigPrettier from "eslint-config-prettier/flat";
+import tseslint from "typescript-eslint";
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  tseslint.configs.strictTypeChecked,
+  eslintConfigPrettier,
+  {
+    languageOptions: {
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+    rules: {
+      "@typescript-eslint/explicit-function-return-type": "error",
+      "@typescript-eslint/no-empty-object-type": "off",
+      "@typescript-eslint/no-floating-promises": [
+        "error",
+        {
+          ignoreVoid: true,
+        },
+      ],
+      "@typescript-eslint/no-non-null-assertion": "off",
+      "@typescript-eslint/no-require-imports": "off",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          argsIgnorePattern: "^_",
+        },
+      ],
+      "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/restrict-template-expressions": "off",
+      "@typescript-eslint/prefer-nullish-coalescing": [
+        "error",
+        {
+          ignoreConditionalTests: true,
+          ignoreMixedLogicalExpressions: true,
+        },
+      ],
+    },
+  },
+);

eslint.config.mjs

@@ -109,6 +109,9 @@
     "pretest": "npm run compile",
     "test": "vscode-test"
   },
+  "prettier": {
+    "plugins": ["prettier-plugin-organize-imports"]
+  },
   "contributes": {
     "breakpoints": [
       {

package.json

@@ -25,10 +25,6 @@
   "settings": {
     "window.title": "PowerShell VS Code Extension Development",
     "debug.onTaskErrors": "prompt",
-    "editor.tabSize": 4,
-    "editor.insertSpaces": true,
-    "files.trimTrailingWhitespace": true,
-    "files.insertFinalNewline": true,
     "files.associations": {
       "**/snippets/*.json": "jsonc", // Use JSONC instead of JSON because that's how VS Code interprets snippet files, and it enables better source documentation.
     },
@@ -46,16 +42,12 @@
     "powershell.codeFormatting.whitespaceBetweenParameters": true,
     "powershell.codeFormatting.pipelineIndentationStyle": "IncreaseIndentationForFirstPipeline",
     "typescript.tsdk": "Client/node_modules/typescript/lib", // Lock the TypeScript SDK path to the version we use
-    "typescript.format.semicolons": "insert", // Code actions like "organize imports" ignore ESLint, so we need this here
-    "eslint.format.enable": true, // Enable ESLint as defaut formatter so quick fixes can be applied directly
     "[typescript]": {
       "editor.defaultFormatter": "esbenp.prettier-vscode",
       "editor.formatOnPaste": true,
       "editor.formatOnSave": true,
       "editor.formatOnSaveMode": "modificationsIfAvailable"
     },
-    "mochaExplorer.configFile": ".mocharc.json",
-    "mochaExplorer.launcherScript": "test/runTests",
     "mochaExplorer.autoload": false, // The test instance pops up every time discovery or run is done, this could be annoying on startup.
     "mochaExplorer.debuggerPort": 59229, // Matches the launch config, we dont want to use the default port as we are launching a duplicate instance of vscode and it might conflict.
     "mochaExplorer.ipcRole": "server",
@@ -95,7 +87,7 @@
     "osx": {
       "options": {
         "shell": {
-          "executable": "/usr/local/bin/pwsh",
+          "executable": "pwsh",
           "args": [
             "-NoProfile",
             "-Command"
@@ -324,15 +316,13 @@
         "sourceMaps": true,
         // This speeds up source map detection and makes smartStep work correctly
         "outFiles": [
-          "${workspaceFolder:Client}/**/*.js",
-          "!**/node_modules/**",
-          "!**/.vscode-test/**"
+          "${workspaceFolder:Client}/dist/*.js"
         ],
         "skipFiles": [
           "<node_internals>/**",
           "**/node_modules/**",
           "**/.vscode-test/**",
-          "**/app/out/vs/**" //Skips Extension Host internals
+          "**/app/out/vs/**" // Skips Extension Host internals
         ],
         "presentation": {
           "hidden": true
@@ -356,9 +346,7 @@
         "sourceMaps": true,
         // This speeds up source map detection and makes smartStep work correctly
         "outFiles": [
-          "${workspaceFolder:Client}/**/*.js",
-          "!**/node_modules/**",
-          "!**/.vscode-test/**"
+          "${workspaceFolder:Client}/dist/*.js"
         ],
         "skipFiles": [
           "<node_internals>/**",
@@ -388,15 +376,13 @@
         "sourceMaps": true,
         // This speeds up source map detection and makes smartStep work correctly
         "outFiles": [
-          "${workspaceFolder:Client}/**/*.js",
-          "!**/node_modules/**",
-          "!**/.vscode-test/**",
+          "${workspaceFolder:Client}/dist/*.js"
         ],
         "skipFiles": [
           "<node_internals>/**",
           "**/node_modules/**",
           "**/.vscode-test/**",
-          "**/app/out/vs/**" //Skips Extension Host internals
+          "**/app/out/vs/**" // Skips Extension Host internals
         ],
         "presentation": {
           "hidden": true
@@ -460,9 +446,7 @@
         "sourceMaps": true,
         // This speeds up source map detection and makes smartStep work correctly
         "outFiles": [
-          "${workspaceFolder:Client}/**/*.js",
-          "!**/node_modules/**",
-          "!**/.vscode-test/**"
+          "${workspaceFolder:Client}/dist/*.js"
         ],
         "skipFiles": [
           "<node_internals>/**",