Fix startup timeout after adjusting sleeps

[andyleejordan]

Glad I remembered this.

[Copilot]

Pull Request Overview

Adjust the session startup timeout logic to account for a reduced sleep interval of 200ms between polls, and remove the old static warning threshold.

• Recompute numOfTries as timeoutSeconds * 5 to match 200ms sleeps
• Update warnAt to subtract a 30-second equivalent in tries instead of using the removed static
• Clarify sleep duration in comments

Comments suppressed due to low confidence (2)

src/process.ts:286

• Update this comment to reflect the new polling interval (200ms) instead of 1 second.

// Check every second.

src/process.ts:282

• Add or update unit tests to verify the new polling logic (200ms sleeps) and ensure warnAt is calculated correctly after this change.

const numOfTries = // We sleep for 1/5 of a second each try

[Copilot]

[nitpick] Replace magic numbers (5 and 30) with named constants (e.g., retriesPerSecond and warnThresholdSeconds) to clarify their purpose.

Suggested change

	5 * this.sessionSettings.developer.waitForSessionFileTimeoutSeconds;
	const warnAt = numOfTries - 5 * 30; // Warn at 30 seconds
	PowerShellProcess.retriesPerSecond * this.sessionSettings.developer.waitForSessionFileTimeoutSeconds;
	const warnAt = numOfTries - PowerShellProcess.retriesPerSecond * PowerShellProcess.warnThresholdSeconds; // Warn at 30 seconds

[SeeminglyScience]

LGTM!