Closed
Conversation
Member
Author
|
Did it work? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #5169 by updating the build and packaging scripts to always use symbolic links for the PSES modules.
- Removed conditional handling for Debug and Release builds in the RestoreEditorServices task to enforce symlink usage.
- Updated the package script in package.json to include the --follow-symlinks flag to support this change.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vscode-powershell.build.ps1 | Removed the configuration-based switch and now always creates a symbolic link for PSES. |
| package.json | Added the --follow-symlinks flag to ensure packaging respects symbolic links for modules. |
Comments suppressed due to low confidence (2)
package.json:108
- [nitpick] Consider updating the project documentation or release notes to explain the new '--follow-symlinks' flag and its impact on the packaging process.
"package": "vsce package --out out/ --no-gitHubIssueLinking --follow-symlinks",
vscode-powershell.build.ps1:36
- The removal of the configuration-specific switch is a significant change. Please confirm that always using a symbolic link for './modules' is intended and update the code comments or documentation to clarify this behavior.
# Always use a symlink for ./modules pointing to PSES
Member
Author
|
This "vibe code" attempt was via the Copilot agent inside a pre-populated codespace for the issue, but now that it's enabled for the PowerShell GitHub organization, I'm having it re-attempt using "assign to Copilot agent" in #5212. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5169.