Skip to content

Fix CI#5436

Merged
andyleejordan merged 2 commits intoPowerShell:mainfrom
liamjpeters:PrettierIgnoreLockFile
Apr 2, 2026
Merged

Fix CI#5436
andyleejordan merged 2 commits intoPowerShell:mainfrom
liamjpeters:PrettierIgnoreLockFile

Conversation

@liamjpeters
Copy link
Copy Markdown
Contributor

@liamjpeters liamjpeters commented Mar 20, 2026

PR Summary

Prettier objects to many things (mainly double quotes) in .github/workflows/issue-triage.lock.yml.

CI has been failing since #5409.

image

As the file is auto-generated, telling Prettier to ignore it and any other generated lock files seems a way forward.

Edit:
Also updated the stable version test from accepting v.7.5 to v7.6; v7.6 is now the advertised stable version. I've left the LTS at v7.4 as that hasn't updated yet.

Gets CI back to passing.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests (NA)
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@liamjpeters liamjpeters requested a review from a team as a code owner March 20, 2026 14:57
@liamjpeters
Copy link
Copy Markdown
Contributor Author

Build progresses past linting now:

image

Fails in the PowerShell update tests as the stable build info URL now reports v7.6.0 🎉🎈.

assert(tag?.startsWith("v7.5") || tag?.startsWith("v7.4"));

@liamjpeters liamjpeters changed the title Add *.lock.yml to prettierignore Add *.lock.yml to prettierignore and update Pwsh Stable to v7.6. Mar 20, 2026
@JustinGrote
Copy link
Copy Markdown
Collaborator

Thanks for your submission! We do need to update tests for 7.6.0 but that's separate. LGTM, CC @andyleejordan

@andyleejordan
Copy link
Copy Markdown
Member

OOPS I started a thing before vacation, it auto-merged, it wasn't actually running...and now it is running somehow and also it broke CI (because somehow it bypassed all rules and literally the quick start AUTOMATICALLY COMMITTED AND MERGED).

Copy link
Copy Markdown
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andyleejordan andyleejordan changed the title Add *.lock.yml to prettierignore and update Pwsh Stable to v7.6. Fix CI Apr 2, 2026
@andyleejordan andyleejordan merged commit 83c2e1f into PowerShell:main Apr 2, 2026
4 checks passed
@liamjpeters liamjpeters deleted the PrettierIgnoreLockFile branch April 3, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants