You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, @jerome-diver, I'm a bit confused about all the changes you make. I think you only want to change prompt_virtualenv. So all your changes would probably be in segments/virtualenv
Could you take another look at your changes?
@Syphdias yes sure, i need one or two days, i'm vry busy actually. I will follow the correct proceed also.
And yes, it is a little change (3 lines i think) for add an option to segment/virtual_env to be able to read python version when inside a python virutalenv environment.
I did allready an other one PR, but i have no time this day to check that... i'll be back for that.
Thank you
hi @Syphdias, i done this pull request instead: #1241
and it seems to be ok.
But i can not see the change inside master official repo. How to make this officialy accepted ? It should be fine if at the next update i can hold this change on my config and i see other users asked for this change. Yu can also delete this one who failed due to my fault...
What do you think about that change ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add an option to be able to show python version from virtualenv activate.