|
| 1 | +from typing import Any |
| 2 | + |
| 3 | +import pytest |
| 4 | + |
| 5 | +from gateframe.core.contract import ValidationContract |
| 6 | +from gateframe.core.failure import FailureMode, FailureResult |
| 7 | +from gateframe.core.retry import RetryPolicy |
| 8 | +from gateframe.core.rule import Rule |
| 9 | + |
| 10 | + |
| 11 | +class _PassingRule(Rule): |
| 12 | + def validate(self, output: Any, **context: Any) -> FailureResult | None: |
| 13 | + return None |
| 14 | + |
| 15 | + |
| 16 | +class _FailingRule(Rule): |
| 17 | + def __init__(self, name: str = "failing", mode: FailureMode = FailureMode.RETRY) -> None: |
| 18 | + super().__init__(name) |
| 19 | + self._mode = mode |
| 20 | + |
| 21 | + def validate(self, output: Any, **context: Any) -> FailureResult | None: |
| 22 | + return FailureResult(rule_name=self.name, failure_mode=self._mode, message="rejected") |
| 23 | + |
| 24 | + |
| 25 | +class _PassOnAttempt(Rule): |
| 26 | + """Passes on the Nth call (1-indexed).""" |
| 27 | + |
| 28 | + def __init__(self, pass_on: int) -> None: |
| 29 | + super().__init__("pass_on_attempt") |
| 30 | + self._pass_on = pass_on |
| 31 | + self._calls = 0 |
| 32 | + |
| 33 | + def validate(self, output: Any, **context: Any) -> FailureResult | None: |
| 34 | + self._calls += 1 |
| 35 | + if self._calls >= self._pass_on: |
| 36 | + return None |
| 37 | + return FailureResult(rule_name=self.name, failure_mode=FailureMode.RETRY, message="not yet") |
| 38 | + |
| 39 | + |
| 40 | +class TestRetryPolicy: |
| 41 | + def test_passes_on_first_attempt(self) -> None: |
| 42 | + contract = ValidationContract("c", [_PassingRule("r")]) |
| 43 | + policy = RetryPolicy(max_retries=2) |
| 44 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 45 | + assert result.succeeded is True |
| 46 | + assert result.attempts == 1 |
| 47 | + |
| 48 | + def test_retries_until_pass(self) -> None: |
| 49 | + rule = _PassOnAttempt(pass_on=3) |
| 50 | + contract = ValidationContract("c", [rule]) |
| 51 | + policy = RetryPolicy(max_retries=3) |
| 52 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 53 | + assert result.succeeded is True |
| 54 | + assert result.attempts == 3 |
| 55 | + |
| 56 | + def test_exhausts_retries_and_fails(self) -> None: |
| 57 | + contract = ValidationContract("c", [_FailingRule(mode=FailureMode.RETRY)]) |
| 58 | + policy = RetryPolicy(max_retries=2) |
| 59 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 60 | + assert result.succeeded is False |
| 61 | + assert result.attempts == 3 # 1 initial + 2 retries |
| 62 | + |
| 63 | + def test_does_not_retry_on_hard_fail(self) -> None: |
| 64 | + contract = ValidationContract("c", [_FailingRule(mode=FailureMode.HARD_FAIL)]) |
| 65 | + policy = RetryPolicy(max_retries=3) |
| 66 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 67 | + assert result.succeeded is False |
| 68 | + assert result.attempts == 1 |
| 69 | + |
| 70 | + def test_does_not_retry_on_soft_fail(self) -> None: |
| 71 | + contract = ValidationContract("c", [_FailingRule(mode=FailureMode.SOFT_FAIL)]) |
| 72 | + policy = RetryPolicy(max_retries=3) |
| 73 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 74 | + assert result.succeeded is False |
| 75 | + assert result.attempts == 1 |
| 76 | + |
| 77 | + def test_retry_failures_passed_to_prompt_fn(self) -> None: |
| 78 | + received: list = [] |
| 79 | + |
| 80 | + def prompt_fn(**ctx: Any) -> dict: |
| 81 | + received.append(ctx.get("retry_failures")) |
| 82 | + return {} |
| 83 | + |
| 84 | + contract = ValidationContract("c", [_FailingRule(mode=FailureMode.RETRY)]) |
| 85 | + policy = RetryPolicy(max_retries=1) |
| 86 | + policy.run(contract, prompt_fn=prompt_fn) |
| 87 | + |
| 88 | + assert received[0] is None # first call has no retry context |
| 89 | + assert received[1] is not None # second call has failures injected |
| 90 | + assert received[1][0].failure_mode is FailureMode.RETRY |
| 91 | + |
| 92 | + def test_context_forwarded_to_contract(self) -> None: |
| 93 | + class _ContextRule(Rule): |
| 94 | + def validate(self, output: Any, **context: Any) -> FailureResult | None: |
| 95 | + if context.get("role") != "admin": |
| 96 | + return FailureResult( |
| 97 | + rule_name=self.name, |
| 98 | + failure_mode=FailureMode.HARD_FAIL, |
| 99 | + message="forbidden", |
| 100 | + ) |
| 101 | + return None |
| 102 | + |
| 103 | + contract = ValidationContract("c", [_ContextRule("role_check")]) |
| 104 | + policy = RetryPolicy() |
| 105 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}, role="admin") |
| 106 | + assert result.succeeded is True |
| 107 | + |
| 108 | + def test_history_contains_all_attempts(self) -> None: |
| 109 | + contract = ValidationContract("c", [_FailingRule(mode=FailureMode.RETRY)]) |
| 110 | + policy = RetryPolicy(max_retries=2) |
| 111 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 112 | + assert len(result.history) == 3 |
| 113 | + |
| 114 | + def test_max_retries_zero_means_single_attempt(self) -> None: |
| 115 | + contract = ValidationContract("c", [_FailingRule(mode=FailureMode.RETRY)]) |
| 116 | + policy = RetryPolicy(max_retries=0) |
| 117 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 118 | + assert result.attempts == 1 |
| 119 | + assert result.succeeded is False |
| 120 | + |
| 121 | + def test_negative_max_retries_raises(self) -> None: |
| 122 | + with pytest.raises(ValueError, match="max_retries"): |
| 123 | + RetryPolicy(max_retries=-1) |
| 124 | + |
| 125 | + def test_retry_result_final_is_last_result(self) -> None: |
| 126 | + contract = ValidationContract("c", [_FailingRule(mode=FailureMode.RETRY)]) |
| 127 | + policy = RetryPolicy(max_retries=1) |
| 128 | + result = policy.run(contract, prompt_fn=lambda **ctx: {}) |
| 129 | + assert result.final is result.history[-1] |
0 commit comments