Skip to content

Commit cc9f778

Browse files
style: apply ruff formatting and fix lint warnings
1 parent e52fd01 commit cc9f778

6 files changed

Lines changed: 24 additions & 18 deletions

File tree

gateframe/audit/log.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,14 @@
1111

1212

1313
class AuditEntry:
14-
__slots__ = ("timestamp", "contract_name", "passed", "rules_applied", "rules_failed", "failures")
14+
__slots__ = (
15+
"timestamp",
16+
"contract_name",
17+
"passed",
18+
"rules_applied",
19+
"rules_failed",
20+
"failures",
21+
)
1522

1623
def __init__(self, result: ValidationResult) -> None:
1724
self.timestamp = datetime.now(timezone.utc)

tests/audit/test_log.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ def _make_result(passed: bool = True, **overrides: object) -> ValidationResult:
99
"contract_name": "test_contract",
1010
"rules_applied": 1,
1111
"rules_failed": 0 if passed else 1,
12-
"failures": [] if passed else [
12+
"failures": []
13+
if passed
14+
else [
1315
FailureResult(
1416
rule_name="rule_a",
1517
failure_mode=FailureMode.HARD_FAIL,
@@ -22,7 +24,6 @@ def _make_result(passed: bool = True, **overrides: object) -> ValidationResult:
2224

2325

2426
class TestAuditLog:
25-
2627
def test_record_adds_entry(self) -> None:
2728
log = AuditLog()
2829
log.record(_make_result())
@@ -49,7 +50,6 @@ def test_entries_returns_copy(self) -> None:
4950

5051

5152
class TestAuditEntry:
52-
5353
def test_entry_structure(self) -> None:
5454
result = _make_result(passed=False)
5555
entry = AuditEntry(result)

tests/core/test_contract.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
from typing import Any
22

3+
import pytest
4+
from pydantic import ValidationError
5+
36
from gateframe.core.contract import ValidationContract, ValidationResult
47
from gateframe.core.failure import FailureMode, FailureResult
58
from gateframe.core.rule import Rule
@@ -11,7 +14,11 @@ def validate(self, output: Any, **context: Any) -> FailureResult | None:
1114

1215

1316
class _FailingRule(Rule):
14-
def __init__(self, name: str = "failing_rule", mode: FailureMode = FailureMode.HARD_FAIL) -> None:
17+
def __init__(
18+
self,
19+
name: str = "failing_rule",
20+
mode: FailureMode = FailureMode.HARD_FAIL,
21+
) -> None:
1522
super().__init__(name)
1623
self._mode = mode
1724

@@ -24,7 +31,6 @@ def validate(self, output: Any, **context: Any) -> FailureResult | None:
2431

2532

2633
class TestValidationContract:
27-
2834
def test_all_rules_pass(self) -> None:
2935
contract = ValidationContract("test", [_PassingRule("a"), _PassingRule("b")])
3036
result = contract.validate({"key": "value"})
@@ -68,11 +74,8 @@ def test_result_has_timestamp(self) -> None:
6874
def test_result_is_frozen(self) -> None:
6975
contract = ValidationContract("test", [_PassingRule("a")])
7076
result = contract.validate({})
71-
try:
77+
with pytest.raises(ValidationError):
7278
result.passed = False # type: ignore[misc]
73-
assert False, "Should have raised"
74-
except Exception:
75-
pass
7679

7780
def test_context_forwarded_to_rules(self) -> None:
7881
class _ContextRule(Rule):
@@ -91,7 +94,6 @@ def validate(self, output: Any, **context: Any) -> FailureResult | None:
9194

9295

9396
class TestValidationResult:
94-
9597
def test_serialization_roundtrip(self) -> None:
9698
result = ValidationResult(
9799
passed=False,

tests/core/test_failure.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
from datetime import datetime, timezone
22

33
import pytest
4+
from pydantic import ValidationError
45

56
from gateframe.core.failure import FailureMode, FailureResult
67

78

89
class TestFailureMode:
9-
1010
def test_has_four_members(self) -> None:
1111
assert len(FailureMode) == 4
1212

@@ -31,7 +31,6 @@ def test_invalid_value_raises(self) -> None:
3131

3232

3333
class TestFailureResult:
34-
3534
def _make_result(self, **overrides: object) -> FailureResult:
3635
defaults = {
3736
"rule_name": "test_rule",
@@ -76,18 +75,18 @@ def test_timestamp_is_utc(self) -> None:
7675

7776
def test_is_frozen(self) -> None:
7877
result = self._make_result()
79-
with pytest.raises(Exception):
78+
with pytest.raises(ValidationError):
8079
result.rule_name = "changed" # type: ignore[misc]
8180

8281
def test_missing_rule_name_raises(self) -> None:
83-
with pytest.raises(Exception):
82+
with pytest.raises(ValidationError):
8483
FailureResult(
8584
failure_mode=FailureMode.HARD_FAIL,
8685
message="something failed",
8786
) # type: ignore[call-arg]
8887

8988
def test_missing_message_raises(self) -> None:
90-
with pytest.raises(Exception):
89+
with pytest.raises(ValidationError):
9190
FailureResult(
9291
rule_name="test",
9392
failure_mode=FailureMode.HARD_FAIL,

tests/core/test_rule.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ def validate(self, output: Any, **context: Any) -> FailureResult | None:
2222

2323

2424
class TestRule:
25-
2625
def test_cannot_instantiate_directly(self) -> None:
2726
with pytest.raises(TypeError):
2827
Rule("test") # type: ignore[abstract]

tests/rules/test_structural.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ class _SampleOutput(BaseModel):
1010

1111

1212
class TestStructuralRule:
13-
1413
def _make_rule(self, **overrides: object) -> StructuralRule:
1514
defaults: dict = {"schema": _SampleOutput}
1615
defaults.update(overrides)

0 commit comments

Comments
 (0)