Skip to content

Added BFS Traversal and solved few buga#543

Merged
Pradeepsingh61 merged 6 commits intoPradeepsingh61:mainfrom
Shubham-Khetan-2005:main
Oct 8, 2025
Merged

Added BFS Traversal and solved few buga#543
Pradeepsingh61 merged 6 commits intoPradeepsingh61:mainfrom
Shubham-Khetan-2005:main

Conversation

@Shubham-Khetan-2005
Copy link
Copy Markdown
Contributor

@Shubham-Khetan-2005 Shubham-Khetan-2005 commented Oct 7, 2025

There was an spacing issue which i fixed in the alignment commit and I tried to make a Better more commented version of ShellSort in C++ which I reverted as the previous PR was merged successfully

Also there was 2 versions of a file - Java/algorithms/sorting/RadixSortREVANT.java and Java/algorithms/sorting/RadixSortRevant.java which was causing trouble as Git can track both RadixSortRevant.java and RadixSortREVANT.java as separate entries internally, but the OS treats them as the same file on disk.
This leads to Git getting confused: it thinks you have two versions of the same file, one staged, one unstaged.
I fixed it and made it to one file - Java/algorithms/sorting/RadixSortRevant.java only

Apart from that The main task was that I added the BFS Traversal Feature to the Repo in Go language

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2025

💎 Code Quality Check Results

❌ Missing Algorithm Description

These files don't explain what the algorithm does:

  • CPP/algorithms/sorting/Shell_Sort.cpp

Required: Add a description explaining the algorithm, its purpose, and how it works

⚠️ Insufficient Comments

These files have very few comments:

  • CPP/algorithms/sorting/Shell_Sort.cpp

Recommended: Add inline comments explaining the logic and key steps

📚 Quality Standards

To maintain high quality, every contribution should include:

  1. ✍️ Algorithm Description

    • Explain what the algorithm does
    • Describe the approach and methodology
    • Include use cases or applications
  2. 📊 Complexity Analysis

    • Time complexity (e.g., O(n log n))
    • Space complexity (e.g., O(n))
    • Brief explanation of why
  3. 💬 Meaningful Comments

    • Explain complex logic
    • Document function parameters
    • Add inline comments for clarity
  4. ✅ Test Cases/Examples

    • Demonstrate the code works
    • Show different input scenarios
    • Include edge cases

💡 Example Template

"""
Binary Search Algorithm

Description: Searches for a target value in a sorted array using divide-and-conquer

Time Complexity: O(log n) - halves search space each iteration
Space Complexity: O(1) - only uses constant extra space
"""

def binary_search(arr, target):
    # Initialize pointers
    left, right = 0, len(arr) - 1

    while left <= right:
        mid = (left + right) // 2

        # Check if target found
        if arr[mid] == target:
            return mid
        # Search right half
        elif arr[mid] < target:
            left = mid + 1
        # Search left half
        else:
            right = mid - 1

    return -1  # Not found

# Test cases
if __name__ == "__main__":
    test_arr = [1, 3, 5, 7, 9]
    print(binary_search(test_arr, 5))  # Output: 2
    print(binary_search(test_arr, 6))  # Output: -1

🔧 How to Fix

  1. Review each file mentioned above
  2. Add the missing documentation
  3. Push your changes
  4. The workflow will re-run automatically

💪 You've Got This!

These checks help maintain quality and make your contribution more valuable to learners. Thank you for taking the time to improve! 🙏


Quality over quantity - let's build something amazing together! 🌟

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2025

🔍 Duplicate Detection Results

⚠️ Potential Duplicates Found

⚠️ Potential Duplicate: CPP/algorithms/sorting/Shell_Sort.cpp
Similar file(s) already exist:

  • CPP/algorithms/sorting/Sorting/C++/Sorting/Shell_sort.cpp
  • CPP/algorithms/sorting/Shell_Sort.cpp

⚠️ Potential Duplicate: Java/algorithms/sorting/RadixSortRevant.java
Similar file(s) already exist:

  • Java/algorithms/sorting/RadixSortRevant.java
  • Java/algorithms/sorting/RadixSortREVANT.java

📝 What This Means

We found existing implementations that appear similar to your contribution. This doesn't necessarily mean your PR will be rejected, but please review:

  1. Is this truly a duplicate? Check the existing files to see if they implement the same algorithm
  2. Is your implementation different/better? If so, explain in your PR description:
    • What makes it different
    • Why it's an improvement
    • Any unique features or optimizations
  3. Consider improving existing code instead of adding a duplicate

✅ What To Do Next

  • If it's a duplicate: Consider withdrawing this PR and improving the existing implementation
  • If it's different: Add a clear explanation in your PR description about how it differs
  • If unsure: Ask the maintainers for guidance!

💡 Quality Over Quantity

Remember: One high-quality, unique contribution is worth more than multiple duplicates! 🌟


This is an automated check. Maintainers will make the final decision.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2025

🎉 Welcome to Hacktoberfest 2025, @Shubham-Khetan-2005! 🎃

Thank you for your first contribution to our DSA repository! Here's what happens next:

🔍 Automatic Checks

  • Code Validation: Passed
  • 🧪 Compilation Tests: Passed

📋 Next Steps

🎯 Great job! Your code compiled successfully. Maintainers @Karanjot786 and @Pradeepsingh61 will review your PR soon.

🎁 What You Get

  • 🏆 Hacktoberfest Credit: This PR counts toward your 6 PR goal for exclusive T-shirt + Tree!
  • 🌟 Hall of Fame: You'll be featured in our contributors list
  • 📚 Learning: Code review feedback from experienced developers

💡 Tips for Success

  • Follow our Contributing Guidelines
  • Add comments explaining your algorithm
  • Include time/space complexity analysis
  • Test your code before submitting

Welcome to the community! 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2025

🤖 Automated PR Status

🔍 Code Validation

Passed - File naming and structure look good!

🧪 Compilation Tests

Passed - All code compiles successfully!

📋 Overall Status

🎉 Ready for Review - Your PR has passed all automated checks!
👥 Maintainers have been notified for review.


This comment was generated automatically. Checks will re-run when you push new commits.

@github-actions github-actions Bot requested a review from Karanjot786 October 7, 2025 17:28
@Pradeepsingh61 Pradeepsingh61 merged commit 136493e into Pradeepsingh61:main Oct 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants