ENH: Show the current time as a vertical line in plot_evoked_topo (mne-tools#14032)

Author: wmvanvliet

doc/changes/dev/14032.newfeature.rst

@@ -0,0 +1 @@
+Make :func:`mne.viz.plot_evoked_topo` show the currently select time with a solid vertical line also in the main figure, by `Marijn van Vliet`_.

examples/visualization/topo_compare_conditions.py

@@ -5,9 +5,9 @@
 Compare evoked responses for different conditions
 =================================================
 
-In this example, an Epochs object for visual and auditory responses is created.
-Both conditions are then accessed by their respective names to create a sensor
-layout plot of the related evoked responses.
+In this example, an Epochs object for visual and auditory responses is created. Both
+conditions are then accessed by their respective names to create a sensor layout plot of
+the related evoked responses.
 
 """
 

mne/viz/tests/test_topo.py

@@ -10,12 +10,7 @@
 import numpy as np
 import pytest
 
-from mne import (
-    Epochs,
-    compute_proj_evoked,
-    read_cov,
-    read_events,
-)
+from mne import Epochs, compute_proj_evoked, read_cov, read_events
 from mne.channels import read_layout
 from mne.io import read_raw_fif
 from mne.time_frequency.tfr import AverageTFRArray
@@ -355,18 +350,24 @@ def test_plot_topo_timechange():
     _fake_click(subfig, ax, (0.5, 0.5), kind="press")
     init_time = ax._selectline.get_xdata()[0]
     assert init_time == 0.0
-
-    # test existence of _current_time in main figure
     assert hasattr(fig, "_current_time")
     assert fig._current_time == 0.0
+    assert hasattr(fig.axes[0]._mne_axs[0], "time_cursor")
 
     # test time change event from subfig and main fig
     ui_events.publish(subfig, ui_events.TimeChange(time=0.1))
     assert ax._selectline.get_xdata()[0] == 0.1
     assert fig._current_time == 0.1
+    for subax in fig.axes[0]._mne_axs:
+        time = 0.1 * subax.x_s + subax.x_t
+        assert subax.time_cursor.get_xdata() == [time, time]
+
     ui_events.publish(subfig, ui_events.TimeChange(time=0.2))
     assert ax._selectline.get_xdata()[0] == 0.2
     assert fig._current_time == 0.2
+    for subax in fig.axes[0]._mne_axs:
+        time = 0.2 * subax.x_s + subax.x_t
+        assert subax.time_cursor.get_xdata() == [time, time]
 
     plt.close("all")
 

mne/viz/topo.py

@@ -14,13 +14,7 @@
 from .._fiff.pick import _FNIRS_CH_TYPES_SPLIT, _picks_to_idx, channel_type, pick_types
 from ..defaults import _handle_default
 from ..utils import Bunch, _check_option, _clean_names, _is_numeric, _to_rgb, fill_doc
-from .ui_events import (
-    ChannelsSelect,
-    TimeChange,
-    link,
-    publish,
-    subscribe,
-)
+from .ui_events import ChannelsSelect, TimeChange, link, publish, subscribe
 from .utils import (
     DraggableColorbar,
     SelectFromCollection,
@@ -670,6 +664,8 @@ def _update_selectline(time):
 
     ax._selectline = None
     ax._selectcolor = "white" if face_brightness < 150 else "black"
+    if orig_fig._current_time is not None:
+        _update_selectline(orig_fig._current_time)
 
     plt.connect("motion_notify_event", _cursor_vline)
     plt.connect("axes_leave_event", _rm_cursor)
@@ -1174,11 +1170,38 @@ def _plot_evoked_topo(
 
     setattr(fig, "_current_time", None)
 
-    def on_time_change(event, fig):
+    def _on_time_change(event, fig, tmin, tmax):
         """Respond to a time change UI event."""
         fig._current_time = event.time
 
-    subscribe(fig, "time_change", partial(on_time_change, fig=fig))
+        # Draw a vertical line at the current time.
+        axs = fig.axes[0]._mne_axs
+        for subax in axs:
+            time = subax.x_s * event.time + subax.x_t
+            if "time_cursor" not in subax:
+                subax["time_cursor"] = subax.ax.axvline(
+                    time,
+                    subax.pos[1],
+                    subax.pos[1] + subax.pos[3],
+                    color=font_color,
+                    linewidth=0.5,
+                )
+            else:
+                subax.time_cursor.set_xdata([time, time])
+            # Hide the vertical line when the time is out of bounds.
+            subax.time_cursor.set_visible(tmin <= event.time <= tmax)
+        fig.canvas.draw()
+
+    subscribe(
+        fig,
+        "time_change",
+        partial(
+            _on_time_change,
+            fig=fig,
+            tmin=np.min([t[0] for t in times]),
+            tmax=np.max([t[-1] for t in times]),
+        ),
+    )
 
     add_background_image(fig, fig_background)