Skip to content

Commit 126c8a9

Browse files
author
Thierry Lacour
committed
Fix #144 Recreate persistent contexts after mixins
1 parent 23e9ebd commit 126c8a9

6 files changed

Lines changed: 15 additions & 10 deletions

File tree

src/main/groovy/togit/ScriptBase.groovy

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,9 @@ abstract class ScriptBase extends Script implements Context {
8484
MigrationManager.instance.source = newSource
8585

8686
// Mix in specific criteria/extraction contexts
87-
newSource.addCriteria()
88-
newSource.addExtractions()
87+
newSource.mixinCriteria()
88+
newSource.mixinExtractions()
89+
MigrationManager.instance.refreshContexts()
8990
}
9091

9192
/**

src/main/groovy/togit/migration/MigrationManager.groovy

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ class MigrationManager {
2727
source = null
2828
targets.clear()
2929
plan = new MigrationPlan()
30+
refreshContexts()
31+
}
32+
33+
void refreshContexts() {
3034
criteriaContext = new CriteriaContext()
3135
extractionsContext = new ExtractionsContext()
3236
actionsContext = new ActionsContext()

src/main/groovy/togit/migration/sources/MigrationSource.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ trait MigrationSource {
3535
/**
3636
* Adds source-specific contexts to the global CriteriaContext
3737
*/
38-
abstract void addCriteria()
38+
abstract void mixinCriteria()
3939

4040
/**
4141
* Adds source-specific contexts to the global ExtractionsContext
4242
*/
43-
abstract void addExtractions()
43+
abstract void mixinExtractions()
4444
}

src/main/groovy/togit/migration/sources/ccbase/ClearCaseSource.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@ class ClearCaseSource implements MigrationSource {
6363
}
6464

6565
@Override
66-
void addCriteria() {
66+
void mixinCriteria() {
6767
CriteriaContext.mixin(ClearCaseCriteriaContext)
6868
}
6969

7070
@Override
71-
void addExtractions() {
71+
void mixinExtractions() {
7272
ExtractionsContext.mixin(ClearCaseExtractionsContext)
7373
}
7474

src/main/groovy/togit/migration/sources/ccucm/CcucmSource.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ class CcucmSource implements MigrationSource {
6565
}
6666

6767
@Override
68-
void addCriteria() {
68+
void mixinCriteria() {
6969
CriteriaContext.mixin(CcucmCriteriaContext)
7070
}
7171

7272
@Override
73-
void addExtractions() {
73+
void mixinExtractions() {
7474
ExtractionsContext.mixin(CcucmExtractionsContext)
7575
}
7676

src/main/groovy/togit/migration/sources/dummy/DummySource.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ class DummySource implements MigrationSource {
4242
}
4343

4444
@Override
45-
void addCriteria() {
45+
void mixinCriteria() {
4646
CriteriaContext.mixin(DummyCriteriaContext)
4747
}
4848

4949
@Override
50-
void addExtractions() {
50+
void mixinExtractions() {
5151
ExtractionsContext.mixin(DummyExtractionsContext)
5252
}
5353
}

0 commit comments

Comments
 (0)