feat(Cripsum.com): add activity#10822
Open
cripsum wants to merge 4 commits into
Open
Conversation
theusaf
requested changes
May 27, 2026
| "description": "Shown while the lootbox animation is playing", | ||
| "message": "Testing their luck" | ||
| }, | ||
| "cripsum.readingArticle": { |
Contributor
There was a problem hiding this comment.
Very similar to general.readingArticle, general.reading or general.readingAbout
| "description": "Shown when reading an article. ' is the article title.", | ||
| "message": "Reading: " | ||
| }, | ||
| "cripsum.readArticle": { |
Contributor
There was a problem hiding this comment.
Duplicate of general.buttonReadArticle
| "description": "Label for the 'Read article' button", | ||
| "message": "Read article" | ||
| }, | ||
| "cripsum.userProfile": { |
Contributor
There was a problem hiding this comment.
Similar to general.viewAProfile
| "description": "Shown when on a profile page but no username is found", | ||
| "message": "Stalking profiles" | ||
| }, | ||
| "cripsum.visitProfile": { |
Contributor
There was a problem hiding this comment.
Similar to general.buttonViewProfile
| "description": "Label for the 'Visit Profile' button", | ||
| "message": "Visit Profile" | ||
| }, | ||
| "cripsum.watchingEdit": { |
Contributor
There was a problem hiding this comment.
Duplicate of general.watching
| "description": "Fallback shown on any other download page", | ||
| "message": "Downloading stuff" | ||
| }, | ||
| "cripsum.store": { |
Contributor
There was a problem hiding this comment.
Duplicate of general.store
Comment on lines
+119
to
+124
| const newLang = await presence.getSetting<string>('lang').catch(() => 'en') | ||
|
|
||
| if (oldLang !== newLang || !strings) { | ||
| oldLang = newLang | ||
| strings = await getStrings() | ||
| } |
Contributor
There was a problem hiding this comment.
oldLang workaround is not needed anymore. Just use const strings = await getStrings()
theusaf
approved these changes
Jun 4, 2026
Bas950
requested changes
Jun 5, 2026
Bas950
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
added new activity: cripsum.com, a website with games, memes and custom profiles
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected