feat: add Nintendo Music presence#10852
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
skullysmods
requested changes
Jun 5, 2026
| "ru": "С Nintendo Music ты можешь слушать разнообразные мелодии Nintendo где угодно." | ||
| }, | ||
| "url": "music.nintendo.com", | ||
| "regExp": "^https?://music\\.nintendo\\.com/", |
Contributor
There was a problem hiding this comment.
Suggested change
| "regExp": "^https?://music\\.nintendo\\.com/", | |
| "regExp": "^https?[:][/][/]music[.]nintendo[.]com[/]", |
Comment on lines
+20
to
+21
| const showTimestamps = await presence.getSetting<boolean>('showTimestamps') | ||
| const showSongArt = await presence.getSetting<boolean>('showSongArt') |
Contributor
There was a problem hiding this comment.
Combine using Promise.all
Comment on lines
+28
to
+31
| { | ||
| "id": "multiLanguage", | ||
| "multiLanguage": true | ||
| }, |
Contributor
There was a problem hiding this comment.
If the strings in your Activity haven't been translated, then this setting is not useful
https://docs.premid.app/v1/guide/localization.html
theusaf
approved these changes
Jun 6, 2026
theusaf
requested review from
a team,
Bas950 and
skullysmods
and removed request for
a team
2 tasks
skullysmods
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nintendo Music Presence
This is a presence for Nintendo Music (domain: music.nintendo.com).
Features
Tested on