fix(brkn.bio): update regex#10854
Open
GustavoSilvadeCarvalho wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gustavo Silva <126930154+GustavoSilvadeCarvalho@users.noreply.github.com>
skullysmods
requested changes
Jun 5, 2026
| }, | ||
| "url": "brkn.bio", | ||
| "regExp": "^https?[:][/][/]brkn[.]bio[/]", | ||
| "regExp": "^https?://(www\\.)?brkn\\.bio/" |
Contributor
There was a problem hiding this comment.
Suggested change
| "regExp": "^https?://(www\\.)?brkn\\.bio/" | |
| "regExp": "^https?[:][/][/](www[.])?brkn[.]bio[/]" |
Contributor
Author
There was a problem hiding this comment.
Hi @skullysmods! Thanks for the review.
My website (brkn.bio) is a bio-link platform, which means the main content and user profiles live in sub-routes (like brkn.bio/maison, brkn.bio/aroc, etc.).
If we keep the strict [/] at the very end of the regex, PreMiD won't trigger the presence script on any user profile page, only on the landing page.
Could we update the regex to allow sub-routes using your pattern, like this?
"regExp": ^https?[:][ /][ /](www[.])?brkn[.]bio[/](.*)?
Let me know if that works, and I'll update the commit right away!
| "url": "brkn.bio", | ||
| "regExp": "^https?[:][/][/]brkn[.]bio[/]", | ||
| "regExp": "^https?://(www\\.)?brkn\\.bio/" | ||
| "version": "1.0.1", |
Contributor
There was a problem hiding this comment.
Suggested change
| "version": "1.0.1", | |
| "version": "1.0.2", |
skullysmods
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix regexp to support
www.brkn.bioURLs.The website redirects users from
brkn.biotowww.brkn.bio, but the previous regexp only matched non-www URLs, preventing the Presence from initializing correctly.Acknowledgements
npm run lintScreenshots
Proof showing the modification is working as expected
N/A — small regexp fix.