Skip to content

feat: post PR asset previews as DiMerP with some personality#10858

Merged
theusaf merged 1 commit into
mainfrom
feat/pr-assets-dimerp
Jun 7, 2026
Merged

feat: post PR asset previews as DiMerP with some personality#10858
theusaf merged 1 commit into
mainfrom
feat/pr-assets-dimerp

Conversation

@Timeraa
Copy link
Copy Markdown
Member

@Timeraa Timeraa commented Jun 6, 2026

Summary

Follow-up to #10856:

  • PR Assets now runs as DiMerP[bot] — the github-script step uses a DiMerP app token (actions/create-github-app-token@v3 with APP_ID/APP_PRIVATE_KEY, same pattern as dns-check.yml/assets-updater.yml), so the asset preview comment and label changes come from DiMerP instead of github-actions[bot]. The job is guarded with if: github.repository_owner == 'PreMiD' since forks don't have the app secrets.
  • The comment got a personality 🤖 — a rotating opener quip (picked by PR number, so it stays stable across pushes to the same PR), a "press F to pay respects" deletion note, and themed empty states + footer. The tables/data are unchanged.

Sample opener: "I fetched these assets so you don't have to. My hobbies include embedding images and silently judging diffs."

Test plan

  • ESLint (incl. workflow schema validation) + actionlint pass
  • Helper fixtures + end-to-end mock scenarios updated for the new copy and pass (incl. quip stability per PR number)
  • DiMerP identity can only be verified live after merge (app secrets exist only upstream — the fork dry-run rig from feat: add PR asset preview comment and activity label sync #10856 can't exercise this part)

- Authenticate via the DiMerP GitHub App token (same pattern as
  dns-check/assets-updater) so comments and labels come from
  DiMerP[bot] instead of github-actions[bot]
- Skip on forks where the app secrets don't exist
- Give the comment a voice: per-PR stable quip, themed deletion/empty
  states and footer
@Timeraa Timeraa requested a review from Bas950 June 6, 2026 17:37
@Bas950 Bas950 requested review from a team, skullysmods and theusaf and removed request for a team June 6, 2026 17:41
@Bas950 Bas950 added repo maintenance General repo maintenance, including updating tools etc chore and removed chore labels Jun 6, 2026
@theusaf theusaf merged commit fe2bc77 into main Jun 7, 2026
9 checks passed
@theusaf theusaf deleted the feat/pr-assets-dimerp branch June 7, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo maintenance General repo maintenance, including updating tools etc

Development

Successfully merging this pull request may close these issues.

3 participants