Fix(Novel Mania): Update selectors & add support for a few features#10961
Fix(Novel Mania): Update selectors & add support for a few features#10961Shulchl wants to merge 25 commits into
Conversation
🖼️ Activity asset previewAsset inspection complete. No pixels were harmed in the making of this comment. 🤖 Novel Mania (
|
| Preview | Source | URL |
|---|---|---|
 |
logo | https://cdn.rcd.gg/PreMiD/websites/N/Novel%20Mania/assets/logo.png |
 |
thumbnail | https://cdn.rcd.gg/PreMiD/websites/N/Novel%20Mania/assets/thumbnail.jpg |
Beep boop — I refresh this comment on every push, so no need to scroll. 🤖
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ations and replacing some others.
| reading: 'general.reading', | ||
| chapter: 'general.chapter', | ||
| lists: 'general.viewAList', | ||
| volume: 'novelmania.volume', |
There was a problem hiding this comment.
| volume: 'novelmania.volume', |
This string does not exist; you can delete it here
| case 'u': /* Seeing some user profile */ | ||
| updateTimestampBySlug('u') | ||
| if (hideInfo) { | ||
| presenceData.state = `${strings.profile} ${strings.privacy}` |
There was a problem hiding this comment.
As I mentioned earlier, this sentence doesn't make sense.
The “general.privacy” string corresponds to “Privacy Policy,” so as it stands, your sentence reads: “Viewing profile of: Privacy Policy”
| delete presenceData.largeImageText | ||
| presenceData.largeImageText = novelName // Its not showing and idk why |
There was a problem hiding this comment.
Currently, the largeImageText isn't displayed because, due to the if condition, it enters the loop only once and then never returns to it.
Your largeImageText therefore appears only once when it goes through the loop upon arriving on the page; once it has passed through, it doesn't go through it again, and the text is cleared.
There was a problem hiding this comment.
Rename the file to Novel Mania.json; otherwise, it won't work.
skullysmods
left a comment
skullysmods
left a comment
There was a problem hiding this comment.
Just to be consistent with the other settings icons in the other Activities
| { | ||
| "id": "hideInfo", | ||
| "title": "Privacy Mode", | ||
| "icon": "fas fa-compress-arrows-alt", |
There was a problem hiding this comment.
| "icon": "fas fa-compress-arrows-alt", | |
| "icon": "fad fa-user-secret", |
| { | ||
| "id": "showTimestamp", | ||
| "title": "Show Timestamp", | ||
| "icon": "fas fa-clock", |
There was a problem hiding this comment.
| "icon": "fas fa-clock", | |
| "icon": "fad fa-stopwatch", |
3 participants
Description
The Novel Mania website has been restructured; consequently, the previous version of the Activity is no longer compatible. In this version, in addition to fixing selectors, support has been added for multilanguage and buttons, as well as "real-time" state updates for filtering of categories, languages and for novel states, while searching a novel on the website. Check it out below.
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected