Skip to content

Attempt to fix bug with codespace pretext view #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscarlevin merged 1 commit into from
Jul 21, 2025
Merged

Attempt to fix bug with codespace pretext view #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ Instructions: Add a subsection under `[Unreleased]` for additions, fixes, change

## [Unreleased]

### Changed

- Template devcontainer will now use versioned docker image

### Fixed

- Bug that sometimes stopped `pretext view` from working in a codespace.

## [2.23.1] - 2025-07-14

Includes updates to core through commit: [c750a05](https://github.com/PreTeXtBook/pretext/commit/c750a05a2c35cad67dd269682e1618e3c1eb63dc)
Expand Down
2 changes: 1 addition & 1 deletion pretext/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
VERSION = get_version("pretext", Path(__file__).parent.parent)


CORE_COMMIT = "acd359af3ce3476249f3a81d14dc93f5dd7ae61e"
CORE_COMMIT = "32262dda4922a4535bcfb10fe1c66b50c51337ac"


def activate() -> None:
Expand Down
5 changes: 3 additions & 2 deletions pretext/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,11 @@ def is_active_server(self) -> bool:
return False
for _, _, _, laddr, _, _ in p.net_connections("all"):
if isinstance(laddr, str):
log.error(
log.debug(
f"BUG: the `pretext view` command encountered an error. Please report this: process {self.pid} with laddr {laddr}"
)
continue
remove_server_entry(self.path_hash)
return False
elif isinstance(laddr.port, int) and laddr.port == self.port:
log.info(f"Found PreTeXt web server at {self.url()}")
return True
Expand Down