add no-push option to pretext deploy#952
Conversation
| @click.option( | ||
| "--no-push", | ||
| is_flag=True, | ||
| required=False, | ||
| help="Do not push to remote. Useful for CI/CD workflows or in case of authentication errors.", |
There was a problem hiding this comment.
It's not clear to me what this does.
There was a problem hiding this comment.
Does it only push the gh-pages branch to deploy? (Not the main/active branch?) Or is this supposed to trigger a CI/CD workflow?
There was a problem hiding this comment.
It does not push anything. So the user (or action) needs to run git push origin gh-pages manually.
There was a problem hiding this comment.
Action deploys should be using https://github.com/marketplace/actions/deploy-github-pages-site rather than a gh-pages branch, so the CI/CD note here is a little confusing.
There was a problem hiding this comment.
Define "should". I would like to allow a workflow where an author could deploy from the command line or an action, which I think needs to use the pretext deploy command. But that doesn't seem to work on an action for authentication reasons. I'm hoping that this would let the action deploy the branch itself
2 participants
This also adds some debug info in case of failures