spadesCBMdb & plot reorganization#84
Merged
Merged
Conversation
camillegiuliano
approved these changes
May 6, 2026
cboisvenue
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some reorganizing to make space for CBM4. Everything that works with the
spadesCBMdbsystem remains.These functions previously took the masterRaster and a table of NPP or total carbon values then created a raster set with these values. This simplifies the functions to accept just the prepared raster which can be generated easily in CBM4. This moves the existing raster creation work into the
spadesCBMdb-specific functions.These were previously prefixed as
CBM-CBM_core_which isn't specific enough with the changing function of CBM_core.I moved the any tests that work directly with the
spadesCBMdbto their own files prefixed withtest-spadesCBMdb. Now the plot tests file just tests the underlying plotting functions (e.g.mapNPP- a function of the NPP raster).