Skip to content

feat: add image preview functionality on bangumi info card#2042

Open
LiggMax wants to merge 1 commit into
Predidit:mainfrom
LiggMax:add-image-preview-functionality-on-bangumi-info-card
Open

feat: add image preview functionality on bangumi info card#2042
LiggMax wants to merge 1 commit into
Predidit:mainfrom
LiggMax:add-image-preview-functionality-on-bangumi-info-card

Conversation

@LiggMax
Copy link
Copy Markdown
Contributor

@LiggMax LiggMax commented May 4, 2026

  • 详情页封面添加图片预览
  • 修改ImageViewer heroTag属性类型 String? to Object?

@Predidit
Copy link
Copy Markdown
Owner

Predidit commented May 4, 2026

感谢你的工作,不过个人觉得这个功能不是很有必要 :D

@LiggMax
Copy link
Copy Markdown
Contributor Author

LiggMax commented May 4, 2026

感谢你的工作,不过个人觉得这个功能不是很有必要 :D

重新提了个pr: #2043,修改了ImageViewer.show的heroTag属性类型和Hero、ImageViewer内PhotoViewHeroAttributes的属性类型统一

1 similar comment
@LiggMax
Copy link
Copy Markdown
Contributor Author

LiggMax commented May 4, 2026

感谢你的工作,不过个人觉得这个功能不是很有必要 :D

重新提了个pr: #2043,修改了ImageViewer.show的heroTag属性类型和Hero、ImageViewer内PhotoViewHeroAttributes的属性类型统一

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants