fix(expo): harden config plugin import and validate it in CI

Author: Preeternal

.github/workflows/ci.yml

@@ -102,6 +102,9 @@ jobs:
                   fs.writeFileSync(path, JSON.stringify(app, null, 2) + '\n');
                   NODE
 
+                  CI=1 npx expo config --json > "$EXPO_WORK_DIR/expo-config.json"
+                  node -e "JSON.parse(require(\"node:fs\").readFileSync(process.argv[1], \"utf8\"))" "$EXPO_WORK_DIR/expo-config.json"
+
                   CI=1 npx expo prebuild --platform all --clean --no-install 2>&1 | tee "$EXPO_WORK_DIR/prebuild.log"
 
                   grep -q "^react_native_file_hash_engine=${ZFH_ENGINE}$" android/gradle.properties
@@ -120,6 +123,14 @@ jobs:
                   fi
                   echo "::endgroup::"
 
+                  echo "::group::expo config"
+                  if [[ -f "$EXPO_WORK_DIR/expo-config.json" ]]; then
+                    cat "$EXPO_WORK_DIR/expo-config.json"
+                  else
+                    echo "Missing: $EXPO_WORK_DIR/expo-config.json"
+                  fi
+                  echo "::endgroup::"
+
                   echo "::group::android/gradle.properties"
                   if [[ -f "$EXPO_WORK_DIR/app/android/gradle.properties" ]]; then
                     cat "$EXPO_WORK_DIR/app/android/gradle.properties"
@@ -145,6 +156,7 @@ jobs:
                   path: |
                       ${{ env.EXPO_WORK_DIR }}/prebuild.log
                       ${{ env.EXPO_WORK_DIR }}/app/app.json
+                      ${{ env.EXPO_WORK_DIR }}/expo-config.json
                       ${{ env.EXPO_WORK_DIR }}/app/android/gradle.properties
                       ${{ env.EXPO_WORK_DIR }}/app/ios/Podfile
 

app.plugin.js

@@ -3,15 +3,17 @@ let configPlugins;
 try {
     configPlugins = require('@expo/config-plugins');
 } catch (error) {
-    if (error?.code !== 'MODULE_NOT_FOUND') {
+    const errorCode = error && error.code;
+    if (errorCode !== 'MODULE_NOT_FOUND') {
         throw error;
     }
     configPlugins = require('expo/config-plugins');
 }
 const { createRunOncePlugin, withPodfile } = configPlugins;
 const withAndroidGradleProperties =
-    configPlugins.withAndroidGradleProperties ??
-    configPlugins.withGradleProperties;
+    typeof configPlugins.withAndroidGradleProperties === 'function'
+        ? configPlugins.withAndroidGradleProperties
+        : configPlugins.withGradleProperties;
 
 if (typeof withAndroidGradleProperties !== 'function') {
     throw new Error(
@@ -25,7 +27,9 @@ const PODFILE_BLOCK_START = '# @preeternal/react-native-file-hash begin';
 const PODFILE_BLOCK_END = '# @preeternal/react-native-file-hash end';
 
 function normalizeEngine(rawEngine) {
-    const engine = (rawEngine ?? 'native').toString().toLowerCase();
+    const normalized =
+        rawEngine == null ? '' : String(rawEngine).trim().toLowerCase();
+    const engine = normalized === '' ? 'native' : normalized;
     if (!VALID_ENGINES.has(engine)) {
         throw new Error(
             `${PLUGIN_NAME}: invalid engine '${rawEngine}'. Expected 'native' or 'zig'.`