ci: remove flaky maestro smoke jobs from main pipeline

Preeternal · Preeternal · commit d8614080ecc7 · 2026-03-15T13:31:13.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -323,161 +323,6 @@ jobs:
             - name: Verify 16KB page alignment (zig)
               run: bash scripts/check-16kb.sh
 
-    maestro-android-smoke:
-        runs-on: ubuntu-latest
-        strategy:
-            fail-fast: false
-            matrix:
-                engine: [native, zig]
-
-        steps:
-            - name: Checkout
-              uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-
-            - name: Setup
-              uses: ./.github/actions/setup
-
-            - name: Install JDK
-              uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
-              with:
-                  distribution: 'zulu'
-                  java-version: '17'
-
-            - name: Install Zig
-              if: matrix.engine == 'zig'
-              uses: ./.github/actions/setup-zig
-
-            - name: Build Zig prebuilts for Android
-              if: matrix.engine == 'zig'
-              run: ./scripts/build-zig-android.sh
-
-            - name: Install Maestro CLI
-              run: |
-                  set -euo pipefail
-                  curl -Ls "https://get.maestro.mobile.dev" | bash
-                  echo "$HOME/.maestro/bin" >> "$GITHUB_PATH"
-
-            - name: Run Maestro runtime smoke (${{ matrix.engine }})
-              uses: reactivecircus/android-emulator-runner@v2
-              with:
-                  api-level: 34
-                  arch: x86_64
-                  emulator-port: 5554
-                  profile: pixel_6
-                  disable-animations: true
-                  emulator-options: -no-window -gpu swiftshader_indirect -no-snapshot -noaudio -no-boot-anim -no-metrics
-                  script: |
-                      ./example/android/gradlew -p example/android :app:assembleRelease :app:installRelease --no-daemon --console=plain -PreactNativeArchitectures=x86_64 -Preact_native_file_hash_engine=${{ matrix.engine }}
-                      ANDROID_SERIAL=emulator-5554 bash ./scripts/maestro-runtime-smoke.sh ${{ matrix.engine }}
-
-            - name: Upload Maestro artifacts (${{ matrix.engine }})
-              if: always()
-              uses: actions/upload-artifact@v4
-              with:
-                  name: maestro-android-${{ matrix.engine }}-artifacts
-                  if-no-files-found: warn
-                  path: ~/.maestro/tests
-
-    maestro-ios-smoke:
-        runs-on: macos-latest
-        strategy:
-            fail-fast: false
-            matrix:
-                engine: [native, zig]
-        env:
-            XCODE_VERSION: latest-stable
-            RCT_USE_RN_DEP: 1
-            RCT_USE_PREBUILT_RNCORE: 1
-            ZFH_ENGINE: ${{ matrix.engine }}
-
-        steps:
-            - name: Checkout
-              uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-
-            - name: Setup
-              uses: ./.github/actions/setup
-
-            - name: Use appropriate Xcode version
-              uses: maxim-lobanov/setup-xcode@60606e260d2fc5762a71e64e74b2174e8ea3c8bd # v1.6.0
-              with:
-                  xcode-version: ${{ env.XCODE_VERSION }}
-
-            - name: Install Zig
-              if: matrix.engine == 'zig'
-              uses: ./.github/actions/setup-zig
-
-            - name: Build Zig prebuilts for iOS
-              if: matrix.engine == 'zig'
-              run: ./scripts/build-zig-ios.sh
-
-            - name: Install CocoaPods dependencies
-              run: |
-                  set -euo pipefail
-                  cd example
-                  bundle install
-                  bundle exec pod install --project-directory=ios --repo-update
-
-            - name: Install Maestro CLI
-              run: |
-                  set -euo pipefail
-                  curl -Ls "https://get.maestro.mobile.dev" | bash
-                  echo "$HOME/.maestro/bin" >> "$GITHUB_PATH"
-
-            - name: Build and install iOS app (${{ matrix.engine }})
-              run: |
-                  set -euo pipefail
-
-                  SIMULATOR_ID=$(xcrun simctl list devices available | awk -F '[()]' '/iPhone/ {print $2; exit}')
-                  if [[ -z "${SIMULATOR_ID}" ]]; then
-                    echo "No available iPhone simulator found" >&2
-                    exit 1
-                  fi
-
-                  xcrun simctl boot "$SIMULATOR_ID" || true
-                  xcrun simctl bootstatus "$SIMULATOR_ID" -b
-
-                  DERIVED_DATA="$RUNNER_TEMP/maestro-ios-${{ matrix.engine }}"
-                  rm -rf "$DERIVED_DATA"
-
-                  xcodebuild \
-                    -workspace example/ios/FileHashExample.xcworkspace \
-                    -scheme FileHashExample \
-                    -configuration Release \
-                    -sdk iphonesimulator \
-                    -destination "id=$SIMULATOR_ID" \
-                    -derivedDataPath "$DERIVED_DATA" \
-                    CODE_SIGNING_ALLOWED=NO \
-                    build
-
-                  APP_PATH=$(find "$DERIVED_DATA/Build/Products/Release-iphonesimulator" -maxdepth 1 -name "*.app" | head -n1)
-                  if [[ -z "${APP_PATH}" ]]; then
-                    echo "Built .app not found in $DERIVED_DATA" >&2
-                    exit 1
-                  fi
-
-                  APP_ID=$(/usr/libexec/PlistBuddy -c "Print :CFBundleIdentifier" "$APP_PATH/Info.plist")
-                  if [[ -z "${APP_ID}" ]]; then
-                    echo "Unable to resolve CFBundleIdentifier" >&2
-                    exit 1
-                  fi
-
-                  xcrun simctl install "$SIMULATOR_ID" "$APP_PATH"
-                  echo "SIMULATOR_ID=$SIMULATOR_ID" >> "$GITHUB_ENV"
-                  echo "APP_ID=$APP_ID" >> "$GITHUB_ENV"
-
-            - name: Run Maestro runtime smoke on iOS (${{ matrix.engine }})
-              run: |
-                  set -euo pipefail
-                  APP_ID="$APP_ID" maestro test ".maestro/runtime-${{ matrix.engine }}-smoke-ios.yaml"
-
-            - name: Upload Maestro artifacts iOS (${{ matrix.engine }})
-              if: always()
-              uses: actions/upload-artifact@v4
-              with:
-                  name: maestro-ios-${{ matrix.engine }}-artifacts
-                  if-no-files-found: warn
-                  path: ~/.maestro/tests
-
     build-ios:
         runs-on: macos-latest
 
diff --git a/.maestro/runtime-native-smoke-ios.yaml b/.maestro/runtime-native-smoke-ios.yaml
@@ -1,7 +1,6 @@
-appId: ${APP_ID}
+appId: "${APP_ID}"
 ---
-- launchApp:
-    clearState: true
+- launchApp
 - extendedWaitUntil:
     visible: "engine: native"
     timeout: 15000
diff --git a/.maestro/runtime-zig-smoke-ios.yaml b/.maestro/runtime-zig-smoke-ios.yaml
@@ -1,7 +1,6 @@
-appId: ${APP_ID}
+appId: "${APP_ID}"
 ---
-- launchApp:
-    clearState: true
+- launchApp
 - extendedWaitUntil:
     visible: "engine: zig"
     timeout: 15000
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -61,8 +61,10 @@ Replace `"<IOS_DEVICE_NAME>"` with your actual iPhone device name.
 ./scripts/build-zig-ios.sh && (cd example && ZFH_ENGINE=zig bundle exec pod install --project-directory=ios && ZFH_ENGINE=zig npx react-native run-ios --mode Release --device "<IOS_DEVICE_NAME>")
 ```
 
+### Local development and rebuilds
+
 If you need a full clean rebuild, run `./gradlew clean` (Android) or clean the
-Xcode build folder before repeating the commands above.
+Xcode build folder before repeating the commands in the sections below.
 
 The [example app](/example/) demonstrates usage of the library. You need to run it to test any changes you make.
 
@@ -124,6 +126,77 @@ Remember to add tests for your change if possible. Run the unit tests by:
 yarn test
 ```
 
+### Local Maestro smoke runs (Android/iOS, native/zig)
+
+Use these commands to run the same Maestro smoke checks locally that CI uses.
+
+Notes:
+
+- If `maestro` is not installed yet, install it once: `curl -Ls "https://get.maestro.mobile.dev" | bash`
+  Then make sure `$HOME/.maestro/bin` is in your `PATH` for the current shell.
+- For Android, set `-PreactNativeArchitectures` to match your local emulator ABI.
+  Apple Silicon emulators are usually `arm64-v8a`; GitHub Actions Linux uses `x86_64`.
+- The Android commands below auto-pick the first connected device from `adb devices`.
+  If you have more than one device/emulator attached, set `ANDROID_SERIAL` manually before running them.
+- For iOS, always pass `--device "$SIMULATOR_ID"` to Maestro. If Android and iOS devices are both running, Maestro can otherwise pick the wrong device.
+
+```sh
+# 1) Android / native / local emulator
+ANDROID_SERIAL="${ANDROID_SERIAL:-$(adb devices | awk '$2 == "device" { print $1; exit }')}"
+[[ -n "$ANDROID_SERIAL" ]] || { echo "No Android device/emulator found" >&2; exit 1; }
+adb -s "$ANDROID_SERIAL" uninstall preeternal.reactnativefilehash.example || true
+./example/android/gradlew -p example/android :app:installRelease --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a -Preact_native_file_hash_engine=native
+ANDROID_SERIAL="$ANDROID_SERIAL" MAESTRO_CLI_NO_ANALYTICS=1 MAESTRO_DRIVER_STARTUP_TIMEOUT=300000 bash ./scripts/maestro-runtime-smoke.sh native
+
+# 2) Android / zig / local emulator
+ANDROID_SERIAL="${ANDROID_SERIAL:-$(adb devices | awk '$2 == "device" { print $1; exit }')}"
+[[ -n "$ANDROID_SERIAL" ]] || { echo "No Android device/emulator found" >&2; exit 1; }
+adb -s "$ANDROID_SERIAL" uninstall preeternal.reactnativefilehash.example || true
+./scripts/build-zig-android.sh
+./example/android/gradlew -p example/android :app:installRelease --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a -Preact_native_file_hash_engine=zig
+ANDROID_SERIAL="$ANDROID_SERIAL" MAESTRO_CLI_NO_ANALYTICS=1 MAESTRO_DRIVER_STARTUP_TIMEOUT=300000 bash ./scripts/maestro-runtime-smoke.sh zig
+
+# 3) iOS / native / local simulator
+SIMULATOR_ID=$(xcrun simctl list devices available | awk -F '[()]' '/iPhone/ {print $2; exit}')
+DERIVED_DATA="$TMPDIR/maestro-ios-native"
+rm -rf "$DERIVED_DATA"
+xcrun simctl boot "$SIMULATOR_ID" || true
+xcrun simctl bootstatus "$SIMULATOR_ID" -b
+(cd example && env -u ZFH_ENGINE bundle exec pod install --project-directory=ios)
+xcodebuild -workspace example/ios/FileHashExample.xcworkspace -scheme FileHashExample -configuration Release -sdk iphonesimulator -destination "id=$SIMULATOR_ID" -derivedDataPath "$DERIVED_DATA" CODE_SIGNING_ALLOWED=NO build
+APP_PATH=$(find "$DERIVED_DATA/Build/Products/Release-iphonesimulator" -maxdepth 1 -name "*.app" | head -n1)
+APP_ID=$(/usr/libexec/PlistBuddy -c "Print :CFBundleIdentifier" "$APP_PATH/Info.plist")
+xcrun simctl uninstall "$SIMULATOR_ID" "$APP_ID" || true
+xcrun simctl install "$SIMULATOR_ID" "$APP_PATH"
+MAESTRO_CLI_NO_ANALYTICS=1 maestro --device "$SIMULATOR_ID" test -e APP_ID="$APP_ID" .maestro/runtime-native-smoke-ios.yaml
+
+# 4) iOS / zig / local simulator
+SIMULATOR_ID=$(xcrun simctl list devices available | awk -F '[()]' '/iPhone/ {print $2; exit}')
+DERIVED_DATA="$TMPDIR/maestro-ios-zig"
+rm -rf "$DERIVED_DATA"
+xcrun simctl boot "$SIMULATOR_ID" || true
+xcrun simctl bootstatus "$SIMULATOR_ID" -b
+./scripts/build-zig-ios.sh
+(cd example && ZFH_ENGINE=zig bundle exec pod install --project-directory=ios)
+xcodebuild -workspace example/ios/FileHashExample.xcworkspace -scheme FileHashExample -configuration Release -sdk iphonesimulator -destination "id=$SIMULATOR_ID" -derivedDataPath "$DERIVED_DATA" CODE_SIGNING_ALLOWED=NO build
+APP_PATH=$(find "$DERIVED_DATA/Build/Products/Release-iphonesimulator" -maxdepth 1 -name "*.app" | head -n1)
+APP_ID=$(/usr/libexec/PlistBuddy -c "Print :CFBundleIdentifier" "$APP_PATH/Info.plist")
+xcrun simctl uninstall "$SIMULATOR_ID" "$APP_ID" || true
+xcrun simctl install "$SIMULATOR_ID" "$APP_PATH"
+MAESTRO_CLI_NO_ANALYTICS=1 maestro --device "$SIMULATOR_ID" test -e APP_ID="$APP_ID" .maestro/runtime-zig-smoke-ios.yaml
+```
+
+### Release checklist
+
+Before publishing a release, run all four local Maestro smoke commands from the section above:
+
+- Android / native
+- Android / zig
+- iOS / native
+- iOS / zig
+
+Maestro smoke is intentionally not part of GitHub Actions CI for this repository.
+Hosted emulator/simulator runs were too slow and too flaky, so these checks are kept local before release.
 
 ### Commit message convention
 
diff --git a/example/ios/FileHashExample/Info.plist b/example/ios/FileHashExample/Info.plist
@@ -36,7 +36,7 @@
 	<key>NSPhotoLibraryUsageDescription</key>
 	<string>This app needs access to your photo library to pick files for hashing.</string>
 	<key>RCTNewArchEnabled</key>
-	<false/>
+	<true/>
 	<key>UILaunchStoryboardName</key>
 	<string>LaunchScreen</string>
 	<key>UIRequiredDeviceCapabilities</key>
diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock
