Skip to content

Commit a169223

Browse files
committed
precise the rules
1 parent 5b3ebce commit a169223

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

content/maintainers-guide/how-to-become-a-committer.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ Committers participate in reviewing code contributions.
1212
## Prerequisites to become a committer
1313

1414
1. **Active participation in the project**
15-
- Have at least one accepted, quality Pull Request.
15+
- Have a record of quality Pull Requests.
1616
- Display a record of Pull Request reviews.
1717
- Real interest in getting involved in code review.
1818
2. **Cultural convergence**
1919
- Respect the Code of Conduct; behave respectfully and in good faith.
20-
- Agree to work together with the rest of the maintainer team towards main goals (see [The Future Architecture][future-architecture]): migration to Symfony, adoption of VueJS ...
20+
- Agree to work together with the rest of the project members towards main goals (see [The Future Architecture][future-architecture]): migration to Symfony, adoption of VueJS ...
2121

2222
## Requirements to continue being a committer
2323

@@ -34,12 +34,12 @@ All the above, plus:
3434
## How to apply to be a committer
3535

3636
1. [Open an issue on the open source repository](https://github.com/PrestaShop/open-source/issues/new) explaining why you apply to become a committer, and on what part of the project (Core or module/subproject).
37-
2. If three maintainers approve the application, the new committer is approved.
37+
2. If three members of the technical council approve the application, the new committer is approved.
3838
3. After 30 days, if the issue did not receive three positive votes, it is considered rejected and closed.
3939

40-
Note: the above process is not mandatory for individuals who are offered the committer role by maintainers, as long as the candidate is supported by at least three maintainers.
40+
Note: the above process is not mandatory for individuals who are offered the committer role by technical council members, as long as the candidate is supported by at least three technical council members.
4141

42-
Upon approval, new committer is granted full committer rights and accesses for a 90-day trial period. This period aims to provide both the maintainer team and the new committer a better understanding of this new arrival and to validate whether expectations meet reality. Both maintainer team or new committer can express their wish for this situation to end before the 90-day trial period, revoking the committer status.
42+
Upon approval, new committer is granted full committer rights and accesses for a 90-day trial period. This period aims to provide both the technical council and the new committer a better understanding of this new arrival and to validate whether expectations meet reality. Both technical council or new committer can express their wish for this situation to end before the 90-day trial period, revoking the committer status.
4343

4444
At the end of the 90-day trial period, the committer is confirmed in his position.
4545

@@ -51,7 +51,7 @@ A project committer status can be revoked for any of the following reasons:
5151
- Lack of activity for the past three months.
5252
- Willful negligence or intent to harm the PrestaShop project.
5353
- On their demand, for personal reasons.
54-
- On request of at least three maintainers.
54+
- On request of at least three members of the technical and/or leadership council, for any reason.
5555

5656
[future-architecture]: https://build.prestashop-project.org/news/2019/prestashop-in-2019-and-beyond-part-3-the-future-architecture/
5757
[slack]: {{< param ProjectUrls.Slack >}}

0 commit comments

Comments
 (0)