fix: swap components over to use the composition api#6
Open
CaramelKat wants to merge 11 commits into
Open
Conversation
Member
binaryoverload
left a comment
There was a problem hiding this comment.
For the theming, instead of setting classes using a query selector across the whole app - I think you should look at using a state management library like https://pinia.vuejs.org/
This will allow you to get/set the theme anywhere in the app - and then set classes on elements appropriately
Comment on lines
+11
to
+14
| if(!document.fonts.check('10px "PixelMplus12-Regular"')) | ||
| window.setTimeout(loadText, 100); | ||
| else | ||
| window.matrix.setText(pages); |
Member
There was a problem hiding this comment.
Is this needed? If we put loadText into an onMount hook then it will always be loaded
This will also cause an infinite loop if the font can't be loaded for some reason
Member
Author
binaryoverload
requested changes
May 24, 2026
Member
binaryoverload
left a comment
There was a problem hiding this comment.
Meant for the previous review to be request changes oops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #XXX
Changes:
Per feedback, updated components to use the composition api instead of the older method for defining props