Update NNAS response/error handling#170
Draft
jonbarrow wants to merge 3 commits into
Draft
Conversation
mrjvs
reviewed
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #160
Changes:
Centralizes the response creation for NNAS. These changes automatically apply the common headers, as well as adds a comment to every response warning users not to share details with untrusted people. Also adds some notes/groundwork for supporting JSON mode in NNAS. Also fixes 3DS cert parsing as a bonus
Some of our error responses were formatted incorrectly, omitting the outer
<errors>tag. This resulted in102-2402(BAD_FORMAT_REQUEST) since the client could not handle the error response. Now that this is fixed, we should get more accurate error codes from usersMarking as draft since it still needs robust testing on a console. I did some quick sanity checks using curl, but that's not enough