fix: fence live checkpoint recovery from PG reinit#264
Open
Abhishek21g wants to merge 1 commit into
Open
Conversation
…#156) Defer maybe_reinit_global_pg while live recovery is in progress and have all ranks wait on the recovery fence before inner steps. Prevents surviving nodes from tearing down global_pg mid send/recv when a peer leaves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live checkpoint P2P transfer used
global_pgwhile surviving ranks could callmaybe_reinit_global_pgduring inner steps — destroying the process group mid send/recv when a node leaves (#156).LiveRecoverycluster-wide fence (begin_recovery/end_recovery/wait_until_recovery_done)maybe_reinit_global_pgwhile recovery is in progresstrain.pywith fence; all ranks wait before outer-step workCloses #156
Verify
uv run pytest tests/test_live_recovery.py -v # Full dist repro: 3-node live recovery with node kill mid-transfer (Linux, 2+ GPU)