|
1 | 1 | import pytest |
2 | 2 |
|
3 | | -from prime_rl.utils.pathing import validate_output_dir |
| 3 | +from prime_rl.utils.pathing import get_log_dir, setup_log_dir, validate_output_dir |
4 | 4 |
|
5 | 5 |
|
6 | 6 | def test_nonexistent_dir_passes(tmp_path): |
@@ -55,3 +55,94 @@ def test_clean_on_nonexistent_dir_is_noop(tmp_path): |
55 | 55 | output_dir = tmp_path / "does_not_exist" |
56 | 56 | validate_output_dir(output_dir, resuming=False, clean=True) |
57 | 57 | assert not output_dir.exists() |
| 58 | + |
| 59 | + |
| 60 | +def test_setup_log_dir_creates_symlink(tmp_path): |
| 61 | + """setup_log_dir creates runs/<uuid>/ and symlinks logs to it.""" |
| 62 | + output_dir = tmp_path / "outputs" |
| 63 | + output_dir.mkdir() |
| 64 | + |
| 65 | + log_dir = setup_log_dir(output_dir) |
| 66 | + |
| 67 | + assert log_dir == output_dir / "logs" |
| 68 | + assert log_dir.is_symlink() |
| 69 | + target = log_dir.resolve() |
| 70 | + assert target.parent == (output_dir / "runs").resolve() |
| 71 | + assert target.is_dir() |
| 72 | + # The symlink target should be a UUID directory under runs/ |
| 73 | + assert target.parent.name == "runs" |
| 74 | + assert len(target.name) == 32 # uuid4().hex length |
| 75 | + |
| 76 | + |
| 77 | +def test_setup_log_dir_writable_through_symlink(tmp_path): |
| 78 | + """Files written through the symlink land in the UUID directory.""" |
| 79 | + output_dir = tmp_path / "outputs" |
| 80 | + output_dir.mkdir() |
| 81 | + |
| 82 | + log_dir = setup_log_dir(output_dir) |
| 83 | + (log_dir / "trainer.log").write_text("test") |
| 84 | + |
| 85 | + target = log_dir.resolve() |
| 86 | + assert (target / "trainer.log").read_text() == "test" |
| 87 | + assert (log_dir / "trainer.log").read_text() == "test" |
| 88 | + |
| 89 | + |
| 90 | +def test_setup_log_dir_creates_fresh_uuid_each_call(tmp_path): |
| 91 | + """Each call to setup_log_dir creates a new UUID run directory.""" |
| 92 | + output_dir = tmp_path / "outputs" |
| 93 | + output_dir.mkdir() |
| 94 | + |
| 95 | + log_dir_1 = setup_log_dir(output_dir) |
| 96 | + target_1 = log_dir_1.resolve() |
| 97 | + |
| 98 | + # Write a file to the first run |
| 99 | + (log_dir_1 / "trainer.log").write_text("run1") |
| 100 | + |
| 101 | + log_dir_2 = setup_log_dir(output_dir) |
| 102 | + target_2 = log_dir_2.resolve() |
| 103 | + |
| 104 | + # New UUID directory |
| 105 | + assert target_1 != target_2 |
| 106 | + # Both directories exist |
| 107 | + assert target_1.is_dir() |
| 108 | + assert target_2.is_dir() |
| 109 | + # Symlink now points to the second run |
| 110 | + assert log_dir_2.resolve() == target_2 |
| 111 | + # First run's files are preserved |
| 112 | + assert (target_1 / "trainer.log").read_text() == "run1" |
| 113 | + |
| 114 | + |
| 115 | +def test_setup_log_dir_resuming_reuses_existing(tmp_path): |
| 116 | + """When resuming and symlink exists, reuse the existing run directory.""" |
| 117 | + output_dir = tmp_path / "outputs" |
| 118 | + output_dir.mkdir() |
| 119 | + |
| 120 | + log_dir_1 = setup_log_dir(output_dir) |
| 121 | + target_1 = log_dir_1.resolve() |
| 122 | + (log_dir_1 / "trainer.log").write_text("run1") |
| 123 | + |
| 124 | + # Resume should reuse the same directory |
| 125 | + log_dir_2 = setup_log_dir(output_dir, resuming=True) |
| 126 | + assert log_dir_2.resolve() == target_1 |
| 127 | + assert (log_dir_2 / "trainer.log").read_text() == "run1" |
| 128 | + |
| 129 | + |
| 130 | +def test_setup_log_dir_resuming_without_symlink_creates_new(tmp_path): |
| 131 | + """When resuming but no symlink exists, create a new run directory.""" |
| 132 | + output_dir = tmp_path / "outputs" |
| 133 | + output_dir.mkdir() |
| 134 | + |
| 135 | + log_dir = setup_log_dir(output_dir, resuming=True) |
| 136 | + assert log_dir.is_symlink() |
| 137 | + assert log_dir.resolve().is_dir() |
| 138 | + |
| 139 | + |
| 140 | +def test_get_log_dir_returns_symlink_path(tmp_path): |
| 141 | + """get_log_dir returns output_dir/logs (the symlink path).""" |
| 142 | + output_dir = tmp_path / "outputs" |
| 143 | + output_dir.mkdir() |
| 144 | + |
| 145 | + setup_log_dir(output_dir) |
| 146 | + log_dir = get_log_dir(output_dir) |
| 147 | + assert log_dir == output_dir / "logs" |
| 148 | + assert log_dir.is_symlink() |
0 commit comments