Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Scoped to vLLM LoRA profiling/warmup in inference patches; no changes to training, auth, or persisted data paths.
Overview
Adds a vLLM inference monkey patch so dummy LoRA warmup during profiling no longer crashes on
FusedMoEWithLoRA(and related MoE LoRA layers) under expert parallelism.The new
monkey_patch_fused_moe_dummy_lorareplacesLoRAModelManager.create_dummy_loraand is registered fromtransformers_v5_compatalongside the other vLLM patches. ForFusedMoEWithLoRA, it limits packed “replacement” slices to the local EP experts and setsn_slicesfrom that narrowed list so dummy weight creation does not index pastmodule.lora_a_stacked(vLLM 0.21.0 bug). It also keeps explicit handling forFusedMoE3DWithLoRAand MoEPackedLoRALayerWeightspacking.Reviewed by Cursor Bugbot for commit e6010e3. Bugbot is set up for automated code reviews on this repo. Configure here.