[codex] Remove vLLM layerwise reload alias patch#2706
Draft
samsja wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prime-rlmonkey patch for vLLM layerwise reload alias buffers._copy_and_restore_kernel_tensorsduring the general plugin setup.Details
vLLM
0.22.0already registersMambaMixer2.conv_weightsas a non-persistent buffer and its layerwise reload metadata skips non-persistent buffers that alias parameter storage. Keeping theprime-rlpatch conflicts with that behavior because the original kernel tensor list can still containconv_weightswhile the temporary restored layer intentionally does not.This returns the checkpoint-format
/update_weightspath to vLLM's own reload implementation.Validation
UV_NO_SYNC=1 uv run ruff check src/prime_rl/inference/patches.pytransformers_v5_compat():layerwise._copy_and_restore_kernel_tensorsremains the original vLLM functionMambaMixer2.__init__registersconv_weightswithpersistent=FalseAttributeErroror parameter corruption23624:Application startup complete4 servers, inference_world_size=16, gpus_per_server=4Reloading checkpoint-format weights with vLLM layerwise processing/update_weightsadmin requests returned200 OKEnabled vLLM layerwise reload alias-buffer patch,conv_weights,AttributeError,Internal Server Error, orTracebackappeared in the runtime logs