Skip to content

Send Prime monitor display config to platform#2709

Merged
d42me merged 5 commits into
mainfrom
fix/prime-monitor-e2e
Jun 12, 2026
Merged

Send Prime monitor display config to platform#2709
d42me merged 5 commits into
mainfrom
fix/prime-monitor-e2e

Conversation

@d42me

@d42me d42me commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Updates PrimeMonitor registration so platform external runs receive the resolved run config and display fields needed for correct dashboard values.

PrimeMonitor is constructed by the orchestrator, so registration now treats run_config as an OrchestratorConfig and reads the fields directly — student.model.name for base_model, train.env for environments, group_size for the platform rollouts_per_example field, plus batch_size, seq_len, max_steps, and the full serialized run_config — instead of duck-typed getattr probing over config shapes that do not reach this code path.

Removed the reviewer-requested PrimeMonitor registration unit test case; the remaining Prime monitor unit tests cover rollout parquet serialization and JSON payload sanitization.

Verified:

  • uvx ruff check tests/unit/utils/test_prime_monitor.py src/prime_rl/utils/monitor/prime.py

Note

Cursor Bugbot is generating a summary for commit b3b9d7f. Configure here.

@d42me d42me force-pushed the fix/prime-monitor-e2e branch from 65bde93 to f1b5889 Compare June 4, 2026 05:14
@d42me

d42me commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Updated this PR with:

  • removed the requested PrimeMonitor registration unit test case
  • fixed external-run environment metadata for RL config shapes where envs live under train.env or orchestrator.train.env

Validation on dev box root@95.133.252.95:

  • pytest -q test_prime_monitor.py → 3 passed
  • ruff check src/prime_rl/utils/monitor/prime.py test_prime_monitor.py → passed
  • prime-rl → platform external-run registration smoke → passed for both orchestrator-shaped and full RLConfig-shaped payloads

@d42me d42me marked this pull request as ready for review June 11, 2026 00:13

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 52b79ea. Configure here.

Comment thread src/prime_rl/utils/monitor/prime.py Outdated
@d42me d42me requested review from mikasenghaas and samsja June 11, 2026 02:52
Comment thread tests/unit/utils/test_prime_monitor.py Outdated
@d42me d42me requested a review from samsja June 12, 2026 00:21
@d42me d42me merged commit c0a026c into main Jun 12, 2026
18 checks passed
@d42me d42me deleted the fix/prime-monitor-e2e branch June 12, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants