Send Prime monitor display config to platform#2709
Merged
Conversation
65bde93 to
f1b5889
Compare
Collaborator
Author
|
Updated this PR with:
Validation on dev box
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 52b79ea. Configure here.
samsja
reviewed
Jun 11, 2026
samsja
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Updates PrimeMonitor registration so platform external runs receive the resolved run config and display fields needed for correct dashboard values.
PrimeMonitoris constructed by the orchestrator, so registration now treatsrun_configas anOrchestratorConfigand reads the fields directly —student.model.nameforbase_model,train.envfor environments,group_sizefor the platformrollouts_per_examplefield, plusbatch_size,seq_len,max_steps, and the full serializedrun_config— instead of duck-typedgetattrprobing over config shapes that do not reach this code path.Removed the reviewer-requested PrimeMonitor registration unit test case; the remaining Prime monitor unit tests cover rollout parquet serialization and JSON payload sanitization.
Verified:
uvx ruff check tests/unit/utils/test_prime_monitor.py src/prime_rl/utils/monitor/prime.pyNote
Cursor Bugbot is generating a summary for commit b3b9d7f. Configure here.