Skip to content

fix: dp=1 EP replicas launch dense-style (vLLM rejects external-LB args at dp=1)#3094

Merged
S1ro1 merged 1 commit into
mainfrom
fix/dp1-ep-launch-dense
Jul 20, 2026
Merged

fix: dp=1 EP replicas launch dense-style (vLLM rejects external-LB args at dp=1)#3094
S1ro1 merged 1 commit into
mainfrom
fix/dp1-ep-launch-dense

Conversation

@mikasenghaas

@mikasenghaas mikasenghaas commented Jul 20, 2026

Copy link
Copy Markdown
Member

Problem

Multi-node inference with enable_expert_parallel and per-node data-parallel size 1 (e.g. tp=8 on 8-GPU nodes → dp_local=1; the "etp8" shape: experts EP-sharded across the node's 8 GPUs, attention at full tp=8) fails to launch. The EP branch in multi_node_rl.sbatch.j2 unconditionally passes vLLM's external-LB DP args, which vLLM rejects when data_parallel_size == 1:

pydantic_core.ValidationError: data_parallel_external_lb can only be set when data_parallel_size > 1

Fix

Guard the external-LB EP launch on INFER_GROUP_DP > 1; for dp=1 EP replicas, launch dense-style (independent single-engine server). enable_expert_parallel in the engine config alone still shards experts across the TP group — no external-LB coordination needed within a single DP rank.

Split out of #3067 as an independent bug fix (the global-router change there is separate and still under evaluation). Validated: etp8 launches and serves cleanly on 8 nodes with this fix; without it, launch crashes at engine init.

🤖 Generated with Claude Code


Note

Low Risk
Narrow SLURM launcher branch change for dp=1 EP; multi-DP EP behavior unchanged when INFER_GROUP_DP > 1.

Overview
Fixes multi-node RL inference launch when enable_expert_parallel is on but the replica’s effective data-parallel size is 1 (e.g. one node with tp=8INFER_GROUP_DP=1).

The EP branch in multi_node_rl.sbatch.j2 now requires INFERENCE_ENABLE_EXPERT_PARALLEL and INFER_GROUP_DP > 1 before passing external load-balancer DP fields (data_parallel_rank, data_parallel_address, RPC port, INFER_GROUP_DP). Otherwise it uses the dense-style launch_inference_rank path (dp=1, no DP coordinator args), because vLLM rejects data_parallel_external_lb when data_parallel_size == 1.

Expert sharding within a single TP group still comes from enable_expert_parallel in the inference config; only cross-rank external-LB coordination is skipped for dp=1 EP.

Reviewed by Cursor Bugbot for commit c0aa31d. Bugbot is set up for automated code reviews on this repo. Configure here.

…gs at dp=1)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mikasenghaas
mikasenghaas requested a review from S1ro1 July 20, 2026 19:58

@S1ro1 S1ro1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@S1ro1
S1ro1 merged commit 5264eb8 into main Jul 20, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants