fix: dp=1 EP replicas launch dense-style (vLLM rejects external-LB args at dp=1)#3094
Merged
Conversation
…gs at dp=1) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multi-node inference with
enable_expert_paralleland per-node data-parallel size 1 (e.g.tp=8on 8-GPU nodes →dp_local=1; the "etp8" shape: experts EP-sharded across the node's 8 GPUs, attention at full tp=8) fails to launch. The EP branch inmulti_node_rl.sbatch.j2unconditionally passes vLLM's external-LB DP args, which vLLM rejects whendata_parallel_size == 1:Fix
Guard the external-LB EP launch on
INFER_GROUP_DP > 1; for dp=1 EP replicas, launch dense-style (independent single-engine server).enable_expert_parallelin the engine config alone still shards experts across the TP group — no external-LB coordination needed within a single DP rank.Split out of #3067 as an independent bug fix (the global-router change there is separate and still under evaluation). Validated: etp8 launches and serves cleanly on 8 nodes with this fix; without it, launch crashes at engine init.
🤖 Generated with Claude Code
Note
Low Risk
Narrow SLURM launcher branch change for dp=1 EP; multi-DP EP behavior unchanged when
INFER_GROUP_DP > 1.Overview
Fixes multi-node RL inference launch when
enable_expert_parallelis on but the replica’s effective data-parallel size is 1 (e.g. one node withtp=8→INFER_GROUP_DP=1).The EP branch in
multi_node_rl.sbatch.j2now requiresINFERENCE_ENABLE_EXPERT_PARALLELandINFER_GROUP_DP > 1before passing external load-balancer DP fields (data_parallel_rank,data_parallel_address, RPC port,INFER_GROUP_DP). Otherwise it uses the dense-stylelaunch_inference_rankpath (dp=1, no DP coordinator args), because vLLM rejectsdata_parallel_external_lbwhendata_parallel_size == 1.Expert sharding within a single TP group still comes from
enable_expert_parallelin the inference config; only cross-rank external-LB coordination is skipped for dp=1 EP.Reviewed by Cursor Bugbot for commit c0aa31d. Bugbot is set up for automated code reviews on this repo. Configure here.