fix(trainer): don't resolve Hub envs when parsing orchestrator configs#3096
Merged
Conversation
discover_runs() builds OrchestratorConfig to read training-relevant fields, but constructing a v1 env config eagerly resolves (imports/installs) its taskset/ harness plugins from the Environments Hub. On the trainer that 404s for private hub envs (taskset.id = owner/name@version) — the trainer has no Hub credentials — so get_orchestrator_config() returns None and the run is silently skipped. Parse under verifiers' skip_plugin_install contextvar so the trainer never touches the Hub; the env server still installs the plugin at runtime. Depends on verifiers exposing `skip_plugin_install` — bump deps/verifiers to a commit that includes it before this lands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
eexwhyzee
force-pushed
the
fix/trainer-skip-plugin-install
branch
from
July 21, 2026 19:22
47aaa5c to
8c29313
Compare
eexwhyzee
marked this pull request as ready for review
July 21, 2026 19:22
mikasenghaas
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
discover_runs()buildsOrchestratorConfigto read training-relevant fields (model, lora, seq_len, buffers, env names), but constructing a v1 env config eagerly resolves (imports/installs) its taskset/harness plugins from the Environments Hub. On the trainer that 404s for private hub envs (taskset.id = owner/name@version) — the trainer has no Hub credentials — soget_orchestrator_config()returnsNoneand the run is silently skipped.Fix
Parse under verifiers'
skip_plugin_installcontextvar so the trainer never touches the Hub while reading the config. The env server still installs the plugin at runtime.Dependency / sequencing
deps/verifiersto a commit that includesskip_plugin_install(separate PR)🤖 Generated with Claude Code
Note
Low Risk
Narrow change to config-load path only; does not alter training or env execution, but adds a hard dependency on the new verifiers API until the submodule is bumped.
Overview
Fixes runs with private v1 Environments Hub tasksets being silently dropped during trainer run discovery.
get_orchestrator_config()now parsesOrchestratorConfigunder verifiers’skip_plugin_installcontext so construction does not resolve or install taskset/harness plugins from the Hub. The trainer only needs training fields from the TOML and never executes the env; without this, private hub refs (taskset.id = owner/name@version) 404 when the trainer has no Hub credentials anddiscover_runs()skips the run. Hub plugin install still happens on the env server at runtime.Note: Depends on a verifiers release that exports
skip_plugin_install(separate submodule bump).Reviewed by Cursor Bugbot for commit 8c29313. Bugbot is set up for automated code reviews on this repo. Configure here.