Fix Windows tunnel runtime support#704
Open
d42me wants to merge 1 commit into
Open
Conversation
255043e to
6fcf85f
Compare
8a6642d to
93256a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on
Tests
Note
Medium Risk
Changes tunnel bootstrap and binary install paths on all platforms (startup ordering and log capture), though behavior is intended to stay equivalent on Unix; new external downloads add supply-chain surface on Windows.
Overview
Adds Windows support for the
frpcclient used by prime-tunnel.Binary delivery: Windows amd64/arm64 release zips are downloaded with SHA256 verification, extracted via
zipfile, and installed asfrpc.exe. Platform detection now normalizesAMD64/ARM64on Windows; Unix tar.gz paths still resolve tofrpc.Tunnel startup: Connection readiness no longer relies on POSIX
fcntlnon-blocking reads. Startup begins pipe-drain threads earlier, captures stdout/stderr into_output_lineswhile_capture_startup_outputis set, and_wait_for_connectionscans that buffered output for success/failure strings—so the same logic works on Windows.Tests cover Windows arch mapping,
frpc.exepath selection, zip extraction, and success detection via the drain path.Reviewed by Cursor Bugbot for commit 93256a9. Bugbot is set up for automated code reviews on this repo. Configure here.