fix clippy match_same_arms warnings (#599)

Author: noot

Cargo.toml

@@ -46,3 +46,8 @@ edition = "2021"
 [workspace.features]
 default = []
 testnet = []
+
+[workspace.lints.clippy]
+match_same_arms = "warn"
+unused_async = "warn"
+uninlined_format_args = "warn"

crates/orchestrator/src/main.rs

@@ -133,7 +133,7 @@ async fn main() -> Result<()> {
         "info" => LevelFilter::Info,
         "debug" => LevelFilter::Debug,
         "trace" => LevelFilter::Trace,
-        _ => LevelFilter::Info, // Default to Info if the level is unrecognized
+        _ => anyhow::bail!("invalid log level: {}", args.log_level),
     };
     env_logger::Builder::new()
         .filter_level(log_level)
@@ -146,10 +146,10 @@ async fn main() -> Result<()> {
         .init();
 
     let server_mode = match args.mode.as_str() {
-        "full" => ServerMode::Full,
         "api" => ServerMode::ApiOnly,
         "processor" => ServerMode::ProcessorOnly,
-        _ => ServerMode::Full,
+        "full" => ServerMode::Full,
+        _ => anyhow::bail!("invalid server mode: {}", args.mode),
     };
 
     debug!("Log level: {log_level}");

crates/orchestrator/src/plugins/node_groups/mod.rs

@@ -627,7 +627,7 @@ impl NodeGroupsPlugin {
                         group.configuration_name.clone(),
                         group.nodes.iter().cloned().collect(),
                     ) {
-                        error!("Failed to send group created webhook: {}", e);
+                        error!("Failed to send group created webhook: {e}");
                     }
                 }
             }
@@ -990,7 +990,7 @@ impl NodeGroupsPlugin {
                         group.configuration_name.clone(),
                         group.nodes.iter().cloned().collect(),
                     ) {
-                        error!("Failed to send group dissolved webhook: {}", e);
+                        error!("Failed to send group dissolved webhook: {e}");
                     }
                 }
             }
@@ -1002,7 +1002,7 @@ impl NodeGroupsPlugin {
                     merged_group.configuration_name.clone(),
                     merged_group.nodes.iter().cloned().collect(),
                 ) {
-                    error!("Failed to send group created webhook: {}", e);
+                    error!("Failed to send group created webhook: {e}");
                 }
             }
         }
@@ -1081,7 +1081,7 @@ impl NodeGroupsPlugin {
                         group.configuration_name.clone(),
                         group.nodes.iter().cloned().collect(),
                     ) {
-                        error!("Failed to send group dissolved webhook: {}", e);
+                        error!("Failed to send group dissolved webhook: {e}");
                     }
                 }
             }

crates/orchestrator/src/store/domains/node_store.rs

@@ -192,6 +192,7 @@ impl NodeStore {
             }
         }
 
+        #[allow(clippy::match_same_arms)]
         nodes.sort_by(|a, b| match (&a.status, &b.status) {
             (NodeStatus::Healthy, NodeStatus::Healthy) => std::cmp::Ordering::Equal,
             (NodeStatus::Healthy, _) => std::cmp::Ordering::Less,

crates/shared/src/models/task.rs

@@ -31,8 +31,7 @@ impl From<&str> for TaskState {
             "FAILED" => TaskState::FAILED,
             "PAUSED" => TaskState::PAUSED,
             "RESTARTING" => TaskState::RESTARTING,
-            "UNKNOWN" => TaskState::UNKNOWN,
-            _ => TaskState::UNKNOWN, // Default case
+            "UNKNOWN" | &_ => TaskState::UNKNOWN,
         }
     }
 }

crates/validator/src/main.rs

@@ -204,15 +204,15 @@ struct Args {
 }
 
 #[tokio::main]
-async fn main() -> Result<(), Box<dyn std::error::Error>> {
+async fn main() -> anyhow::Result<()> {
     let args = Args::parse();
     let log_level = match args.log_level.as_str() {
         "error" => LevelFilter::Error,
         "warn" => LevelFilter::Warn,
         "info" => LevelFilter::Info,
         "debug" => LevelFilter::Debug,
         "trace" => LevelFilter::Trace,
-        _ => LevelFilter::Info,
+        _ => anyhow::bail!("invalid log level: {}", args.log_level),
     };
     env_logger::Builder::new()
         .filter_level(log_level)

crates/validator/src/validators/synthetic_data/chain_operations.rs

@@ -29,7 +29,7 @@ impl SyntheticDataValidator<WalletProvider> {
             .await?
             .ok_or_else(|| Error::msg("Work info not found for soft invalidation"))?;
         let work_key_bytes = hex::decode(work_key)
-            .map_err(|e| Error::msg(format!("Failed to decode hex work key: {}", e)))?;
+            .map_err(|e| Error::msg(format!("Failed to decode hex work key: {e}")))?;
 
         // Create 64-byte payload: work_key (32 bytes) + work_units (32 bytes)
         let mut data = Vec::with_capacity(64);
@@ -46,8 +46,8 @@ impl SyntheticDataValidator<WalletProvider> {
         {
             Ok(_) => Ok(()),
             Err(e) => {
-                error!("Failed to soft invalidate work {}: {}", work_key, e);
-                Err(Error::msg(format!("Failed to soft invalidate work: {}", e)))
+                error!("Failed to soft invalidate work {work_key}: {e}");
+                Err(Error::msg(format!("Failed to soft invalidate work: {e}")))
             }
         }
     }
@@ -85,16 +85,16 @@ impl SyntheticDataValidator<WalletProvider> {
         }
 
         let data = hex::decode(work_key)
-            .map_err(|e| Error::msg(format!("Failed to decode hex work key: {}", e)))?;
+            .map_err(|e| Error::msg(format!("Failed to decode hex work key: {e}")))?;
         match self
             .prime_network
             .invalidate_work(self.pool_id, self.penalty, data)
             .await
         {
             Ok(_) => Ok(()),
             Err(e) => {
-                error!("Failed to invalidate work {}: {}", work_key, e);
-                Err(Error::msg(format!("Failed to invalidate work: {}", e)))
+                error!("Failed to invalidate work {work_key}: {e}");
+                Err(Error::msg(format!("Failed to invalidate work: {e}")))
             }
         }
     }

crates/worker/src/checks/issue.rs

@@ -24,11 +24,15 @@ pub enum IssueType {
 impl IssueType {
     pub const fn severity(&self) -> Severity {
         match self {
-            Self::NetworkConnectivityIssue => Severity::Warning,
-            Self::InsufficientCpu => Severity::Warning,
-            Self::InsufficientMemory => Severity::Warning,
-            Self::InsufficientStorage => Severity::Warning,
-            _ => Severity::Error,
+            Self::NetworkConnectivityIssue
+            | Self::InsufficientCpu
+            | Self::InsufficientMemory
+            | Self::InsufficientStorage => Severity::Warning,
+            Self::NoGpu
+            | Self::DockerNotInstalled
+            | Self::ContainerToolkitNotInstalled
+            | Self::NoStoragePath
+            | Self::PortUnavailable => Severity::Error,
         }
     }
 }

crates/worker/src/cli/command.rs

@@ -687,7 +687,7 @@ pub async fn execute_command(
             };
 
             if let Err(e) = p2p_service.start() {
-                error!("❌ Failed to start P2P listener: {}", e);
+                error!("❌ Failed to start P2P listener: {e}");
                 std::process::exit(1);
             }
 

crates/worker/src/docker/docker_manager.rs

@@ -784,9 +784,10 @@ impl DockerManager {
             match log_result {
                 Ok(log_output) => {
                     let message_bytes = match log_output {
-                        LogOutput::StdOut { message } | LogOutput::StdErr { message } => message,
-                        LogOutput::Console { message } => message,
-                        LogOutput::StdIn { message } => message,
+                        LogOutput::StdOut { message }
+                        | LogOutput::StdErr { message }
+                        | LogOutput::Console { message }
+                        | LogOutput::StdIn { message } => message,
                     };
 
                     // Strip ANSI escape sequences, skipping on error.