Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Commit 59e6ccc

Browse files
authored
Feature: Group size in storage variables (#343)
* add node_group_size in file_name_template
1 parent e5cf9cc commit 59e6ccc

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

crates/orchestrator/src/api/routes/storage.rs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ async fn request_upload(
114114
match plugin.get_node_group(address) {
115115
Ok(Some(group)) => {
116116
file_name = file_name.replace("${node_group_id}", &group.id);
117+
file_name =
118+
file_name.replace("${node_group_size}", &group.nodes.len().to_string());
117119
let idx = plugin.get_idx_in_group(&group, address).unwrap();
118120
file_name = file_name.replace("${node_group_index}", &idx.to_string());
119121
}
@@ -414,7 +416,7 @@ mod tests {
414416
name: "test-task".to_string(),
415417
storage_config: Some(StorageConfig {
416418
file_name_template: Some(
417-
"model_123/${node_group_id}-${node_group_index}-${original_name}".to_string(),
419+
"model_xyz/dataset_1/${node_group_id}-${node_group_size}-${node_group_index}.parquet".to_string(),
418420
),
419421
}),
420422
..Default::default()
@@ -454,7 +456,12 @@ mod tests {
454456
assert_eq!(json["success"], serde_json::Value::Bool(true));
455457
assert_eq!(
456458
json["file_name"],
457-
serde_json::Value::String(format!("model_123/{}-{}-test.parquet", group.id, 0))
459+
serde_json::Value::String(format!(
460+
"model_xyz/dataset_1/{}-{}-{}.parquet",
461+
group.id,
462+
group.nodes.len(),
463+
0
464+
))
458465
);
459466
}
460467
}

0 commit comments

Comments
 (0)