Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Commit f3a392c

Browse files
authored
add test to workkey logging on validator (#382)
* add test to workkey logging on validator
1 parent d60d206 commit f3a392c

1 file changed

Lines changed: 17 additions & 2 deletions

File tree

  • crates/validator/src/validators/synthetic_data

crates/validator/src/validators/synthetic_data/mod.rs

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -668,6 +668,10 @@ impl SyntheticDataValidator {
668668
}
669669
}
670670

671+
info!(
672+
"keys_to_process: {} (including keys with no status or pending status)",
673+
keys_to_process
674+
);
671675
if let Some(metrics) = &self.metrics {
672676
metrics.record_work_keys_to_process(keys_to_process as f64);
673677
}
@@ -1236,6 +1240,7 @@ mod tests {
12361240
.create();
12371241

12381242
let storage_provider = Arc::new(mock_storage);
1243+
let metrics_context = MetricsContext::new("0".to_string(), Some("0".to_string()));
12391244

12401245
let validator = SyntheticDataValidator::new(
12411246
"0".to_string(),
@@ -1251,7 +1256,7 @@ mod tests {
12511256
1,
12521257
true,
12531258
false,
1254-
None,
1259+
Some(metrics_context),
12551260
);
12561261

12571262
let work_keys: Vec<String> = vec![file_sha.to_string()];
@@ -1271,6 +1276,9 @@ mod tests {
12711276
let plan = validator.build_validation_plan(work_keys).await?;
12721277
assert_eq!(plan.group_trigger_tasks.len(), 1);
12731278
assert_eq!(plan.group_trigger_tasks[0].group_id, group_id);
1279+
let metrics_0 = export_metrics().unwrap();
1280+
assert!(metrics_0
1281+
.contains("validator_work_keys_to_process{pool_id=\"0\",validator_id=\"0\"} 1"));
12741282

12751283
let group = validator.get_group(file_sha).await?;
12761284
assert!(group.is_some());
@@ -1291,6 +1299,11 @@ mod tests {
12911299
assert_eq!(plan_2.group_trigger_tasks.len(), 0);
12921300
assert_eq!(plan_2.group_status_check_tasks.len(), 1);
12931301

1302+
let metrics = export_metrics().unwrap();
1303+
assert!(
1304+
metrics.contains("validator_work_keys_to_process{pool_id=\"0\",validator_id=\"0\"} 1")
1305+
);
1306+
12941307
let result = validator
12951308
.process_group_status_check(plan_2.group_status_check_tasks[0].clone())
12961309
.await;
@@ -1304,6 +1317,9 @@ mod tests {
13041317
let plan_3 = validator.build_validation_plan(work_keys_3).await?;
13051318
assert_eq!(plan_3.group_trigger_tasks.len(), 0);
13061319
assert_eq!(plan_3.group_status_check_tasks.len(), 0);
1320+
let metrics_2 = export_metrics().unwrap();
1321+
assert!(metrics_2
1322+
.contains("validator_work_keys_to_process{pool_id=\"0\",validator_id=\"0\"} 0"));
13071323

13081324
Ok(())
13091325
}
@@ -1385,7 +1401,6 @@ mod tests {
13851401
let file =
13861402
"Qwen/Qwen3-14B/PrimeIntellect/INTELLECT-2-RL-Dataset/1-d4eb155339fc64e-1-20-0.parquet";
13871403
let group_info = GroupInformation::from_str(file)?;
1388-
println!("group_info: {:?}", group_info);
13891404
Ok(())
13901405
}
13911406
}

0 commit comments

Comments
 (0)