Skip to content

Commit 7211661

Browse files
fix: default rollout max_retries to 3 (#1533)
Default the eval rollout retry count for transient infrastructure errors to 3 instead of 0, via EvalConfig.max_retries, the `vf-eval --max-retries` CLI flag, and the eval config ingestion default. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 82e6044 commit 7211661

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

docs/reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1132,7 +1132,7 @@ class EvalConfig(BaseModel):
11321132
max_concurrent: int
11331133
independent_scoring: bool = False
11341134
extra_env_kwargs: dict = {}
1135-
max_retries: int = 0
1135+
max_retries: int = 3
11361136
verbose: bool = False
11371137
state_columns: list[str] | None = None
11381138
save_results: bool = False

verifiers/scripts/eval.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -594,8 +594,8 @@ def build_parser() -> argparse.ArgumentParser:
594594
parser.add_argument(
595595
"--max-retries",
596596
type=int,
597-
default=0,
598-
help="Max retries for transient infrastructure errors (default: 0)",
597+
default=3,
598+
help="Max retries for transient infrastructure errors (default: 3)",
599599
)
600600
parser.add_argument(
601601
"--disable-env-server",
@@ -958,7 +958,7 @@ def build_eval_config(raw: dict) -> EvalConfig:
958958
num_examples=num_examples,
959959
rollouts_per_example=rollouts_per_example,
960960
max_concurrent=raw.get("max_concurrent", DEFAULT_MAX_CONCURRENT),
961-
max_retries=raw.get("max_retries", 0),
961+
max_retries=raw.get("max_retries", 3),
962962
num_workers=raw.get("num_workers", "auto"),
963963
disable_env_server=raw.get("disable_env_server", False),
964964
verbose=raw.get("verbose", False),

verifiers/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1329,7 +1329,7 @@ class EvalConfig(BaseModel):
13291329
num_workers: int | str = "auto"
13301330
independent_scoring: bool = False
13311331
extra_env_kwargs: dict = {}
1332-
max_retries: int = 0
1332+
max_retries: int = 3
13331333
disable_env_server: bool = False
13341334
# logging
13351335
verbose: bool = False

0 commit comments

Comments
 (0)