Skip to content

Feat/autodiff/rnn#1723

Open
SamKG wants to merge 8 commits into
PrincetonUniversity:develfrom
SamKG:feat/autodiff/rnn
Open

Feat/autodiff/rnn#1723
SamKG wants to merge 8 commits into
PrincetonUniversity:develfrom
SamKG:feat/autodiff/rnn

Conversation

@SamKG
Copy link
Copy Markdown
Collaborator

@SamKG SamKG commented Jul 21, 2020

No description provided.

@SamKG SamKG requested a review from jvesely July 21, 2020 14:37
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com Bot commented Jul 21, 2020

This pull request introduces 35 alerts and fixes 2 when merging a5bff96 into 07af715 - view on LGTM.com

new alerts:

  • 24 for Unused import
  • 9 for Unused local variable
  • 1 for Asserting a tuple
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

@SamKG SamKG force-pushed the feat/autodiff/rnn branch from a5bff96 to 217d244 Compare July 21, 2020 16:36
@SamKG
Copy link
Copy Markdown
Collaborator Author

SamKG commented Jul 21, 2020

retest this please

@SamKG SamKG force-pushed the feat/autodiff/rnn branch 2 times, most recently from b0e025a to 60cd1d4 Compare July 21, 2020 17:14
@SamKG
Copy link
Copy Markdown
Collaborator Author

SamKG commented Jul 21, 2020

retest this please

@SamKG SamKG force-pushed the feat/autodiff/rnn branch 2 times, most recently from 2d09de1 to d20fa6f Compare July 21, 2020 17:47
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com Bot commented Jul 21, 2020

This pull request introduces 2 alerts and fixes 2 when merging d20fa6f into 07af715 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

jvesely
jvesely requested changes Jul 23, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jvesely jvesely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mxm and outer_product parts look.

The rest of the compiled parts needs significant rework to use standard tools (or add comments why that is not possible)

Comment thread psyneulink/core/compositions/composition.py Outdated
Comment thread psyneulink/core/llvm/builtins.py Outdated
Comment thread psyneulink/library/components/mechanisms/processing/transfer/lstmmechanism.py Outdated
Comment thread psyneulink/library/components/mechanisms/processing/transfer/lstmmechanism.py Outdated
Comment thread psyneulink/library/components/mechanisms/processing/transfer/lstmmechanism.py
Comment thread psyneulink/library/components/mechanisms/processing/transfer/lstmmechanism.py Outdated
Comment thread psyneulink/library/components/mechanisms/processing/transfer/lstmmechanism.py Outdated
Comment thread psyneulink/library/components/mechanisms/processing/transfer/lstmmechanism.py Outdated
Comment thread tests/llvm/test_builtins_matrix.py Outdated
Comment thread tests/llvm/test_builtins_vector.py
@jvesely
Copy link
Copy Markdown
Collaborator

jvesely commented Jul 23, 2020

The mxm and outer_product parts look.

The rest of the compiled parts needs significant rework to use standard tools (or add comments why that is not possible)

To be more specific here. I think the LSTM function should have its own class rather than a rather hacky approach of using UDF, since you're writing the important parts anyway it shouldn't be too difficult and it will lead to clearer structure (including LLVM implementation). It should also have standalone tests.

Custom _get_state_struct and _get_param_struct should be avoided if possible. The reason why mechanism's function is not included by default is the presence of special functions (like memory functions). Other Function typed parameters should work without any special handling.

@SamKG SamKG force-pushed the feat/autodiff/rnn branch from d20fa6f to 5a083e6 Compare July 25, 2020 22:39
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com Bot commented Jul 25, 2020

This pull request introduces 2 alerts and fixes 2 when merging 5a083e6 into c7afc35 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

@SamKG SamKG force-pushed the feat/autodiff/rnn branch 2 times, most recently from 42e66e8 to 45c5d1d Compare July 26, 2020 05:27
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com Bot commented Jul 26, 2020

This pull request introduces 3 alerts and fixes 2 when merging 45c5d1d into c7afc35 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

@SamKG SamKG force-pushed the feat/autodiff/rnn branch from 45c5d1d to b176980 Compare July 27, 2020 03:54
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com Bot commented Jul 27, 2020

This pull request introduces 3 alerts and fixes 2 when merging b176980 into c7afc35 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

@SamKG SamKG force-pushed the feat/autodiff/rnn branch from b176980 to fe18306 Compare July 27, 2020 04:37
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com Bot commented Jul 27, 2020

This pull request introduces 2 alerts and fixes 2 when merging fe18306 into c7afc35 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

@SamKG SamKG force-pushed the feat/autodiff/rnn branch from fe18306 to b99cd4b Compare July 28, 2020 14:52
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com Bot commented Jul 28, 2020

This pull request introduces 2 alerts and fixes 2 when merging b99cd4b into e31dc28 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvesely jvesely jvesely requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SamKG @jvesely