Changes required to support the latest EM Compositon on psnlv#3177
Open
ddelpiano wants to merge 2 commits into
Open
Changes required to support the latest EM Compositon on psnlv#3177ddelpiano wants to merge 2 commits into
ddelpiano wants to merge 2 commits into
Conversation
ddelpiano
commented
Jan 29, 2025
- Changes suggested by Katrine to support the EMComposition viewer wise
- grpc from psyneulink are an old version and the viewer uses a more recent version causing a conflict, since these are not used anymore we commented the import (I can do a clean up later if this is fine).
… with the latest rpc version
Collaborator
|
Hi, I think the changes in #3218 should fix the EMComposition in a more general way than what I gave you before, specifically this change: https://github.com/PrincetonUniversity/PsyNeuLink/pull/3218/files#diff-c671c021254f77d644246afac5244674ac47f284228d2942c97bcd5fde82c662 Parameters labeled as |
Author
|
Thanks @kmantel , should close this then? |
Collaborator
|
@ddelpiano they don't affect anything related to RPC, which I see is included here. Do we need to upgrade the protobuf (?) package or remove the psyneulink rpc module? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.