Skip to content

Changes required to support the latest EM Compositon on psnlv#3177

Open
ddelpiano wants to merge 2 commits into
PrincetonUniversity:develfrom
ddelpiano:feature/psnlviewer
Open

Changes required to support the latest EM Compositon on psnlv#3177
ddelpiano wants to merge 2 commits into
PrincetonUniversity:develfrom
ddelpiano:feature/psnlviewer

Conversation

@ddelpiano
Copy link
Copy Markdown

  • Changes suggested by Katrine to support the EMComposition viewer wise
  • grpc from psyneulink are an old version and the viewer uses a more recent version causing a conflict, since these are not used anymore we commented the import (I can do a clean up later if this is fine).

@kmantel
Copy link
Copy Markdown
Collaborator

kmantel commented Feb 26, 2025

Hi, I think the changes in #3218 should fix the EMComposition in a more general way than what I gave you before, specifically this change: https://github.com/PrincetonUniversity/PsyNeuLink/pull/3218/files#diff-c671c021254f77d644246afac5244674ac47f284228d2942c97bcd5fde82c662

Parameters labeled as pnl_internal or not bypassed this problem, but this labeling should be more of a superficial difference that I think shouldn't matter for what you need.

@ddelpiano
Copy link
Copy Markdown
Author

Thanks @kmantel , should close this then?

@kmantel
Copy link
Copy Markdown
Collaborator

kmantel commented Mar 4, 2025

@ddelpiano they don't affect anything related to RPC, which I see is included here. Do we need to upgrade the protobuf (?) package or remove the psyneulink rpc module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants