fix: prevent latch inference#135
Open
tianrui-wei wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
Contributor
Author
Contributor
|
I don't remember exactly why did I comment that out.. Just checked the L15 decoder, and I found that it didn't look into the data_size field. I think in L15 pipeline it will use the data size stored in MSHR. So, we are okay to set the default data_size to 0. But If you have other modules that need the data_size info, the best way might be just uncomment those lines back (or set default data size to data_size_S4_f). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents latch inference by assigning a default value to
msg_send_data_size_S4