feat(config): add database connection enable/disable flags and fix entity mappings

ranganathan2020 · claude · ranganathan2020 · commit 6956dd01b8b4 · 2026-02-13T19:15:08.000Z
- Add SQL_CONNECTIONENABLE, MYSQL_CONNECTIONENABLE, POSTGRES_CONNECTIONENABLE env vars
- Add DatabaseConnections section in appsettings.json for config-file based control
- Fix websiteCode entity mapping from string to int (matches DB column type)
- Fix TPartnerCode entity mapping from nullable to non-nullable (matches DB)
- Add alert recipients: muhammad.zakir, yarik.sobanski, michael.sobanski
- Update all unit and integration tests for corrected entity types

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/OrderMonitor.Api/appsettings.Development.json b/src/OrderMonitor.Api/appsettings.Development.json
@@ -1,4 +1,10 @@
 {
+  "DatabaseConnections": {
+    "SqlConnectionEnable": true,
+    "MySqlConnectionEnable": false,
+    "PostgresConnectionEnable": false
+  },
+
   "ConnectionStrings": {
     "BackofficeDb": "Server=10.10.30.7,1433;Database=PrinterPix_BO_Live;User Id=db_PIX_BackOffice_Live;Password={ENCRYPTED};TrustServerCertificate=True;ApplicationIntent=ReadOnly;"
   },
@@ -24,7 +30,12 @@
 
   "Alerts": {
     "Enabled": true,
-    "Recipients": ["ranganathan.e@syncoms.com"],
+    "Recipients": [
+      "ranganathan.e@syncoms.com",
+      "muhammad.zakir@syncoms.co.uk",
+      "yarik.sobanski@syncoms.co.uk",
+      "michael.sobanski@syncoms.co.uk"
+    ],
     "SubjectPrefix": "[Order Monitor]"
   },
 
diff --git a/src/OrderMonitor.Api/appsettings.json b/src/OrderMonitor.Api/appsettings.json
@@ -1,4 +1,10 @@
 {
+  "DatabaseConnections": {
+    "SqlConnectionEnable": true,
+    "MySqlConnectionEnable": false,
+    "PostgresConnectionEnable": false
+  },
+
   "ConnectionStrings": {
     "BackofficeDb": "Server=localhost;Database=Backoffice;Trusted_Connection=True;TrustServerCertificate=True;ApplicationIntent=ReadOnly;"
   },
@@ -25,7 +31,10 @@
   "Alerts": {
     "Enabled": true,
     "Recipients": [
-      "ranganathan.e@syncoms.com"
+      "ranganathan.e@syncoms.com",
+      "muhammad.zakir@syncoms.co.uk",
+      "yarik.sobanski@syncoms.co.uk",
+      "michael.sobanski@syncoms.co.uk"
     ],
     "SubjectPrefix": "[Order Monitor]"
   },
diff --git a/src/OrderMonitor.Infrastructure/Data/EfCoreOrderRepository.cs b/src/OrderMonitor.Infrastructure/Data/EfCoreOrderRepository.cs
@@ -79,9 +79,9 @@ where opt.IsPrimaryComponent
                 StuckSince = o.LastUpdatedDate!.Value,
                 HoursStuck = (int)(utcNow - o.LastUpdatedDate!.Value).TotalHours,
                 ThresholdHours = OrderStatusConfiguration.GetThresholdHours(o.Status),
-                Region = o.WebsiteCode,
+                Region = o.WebsiteCode.ToString(),
                 CustomerEmail = null,
-                FacilityCode = o.FacilityCode?.ToString(),
+                FacilityCode = o.FacilityCode.ToString(),
                 FacilityName = o.FacilityName ?? "Unknown"
             });
 
diff --git a/src/OrderMonitor.Infrastructure/Data/Entities/ConsolidationOrderEntity.cs b/src/OrderMonitor.Infrastructure/Data/Entities/ConsolidationOrderEntity.cs
@@ -19,8 +19,7 @@ public class ConsolidationOrderEntity
     public string? OrderNumber { get; set; }
 
     [Column("websiteCode")]
-    [StringLength(20)]
-    public string? WebsiteCode { get; set; }
+    public int WebsiteCode { get; set; }
 
     public ICollection<OrderProductTrackingEntity> OrderProductTrackings { get; set; } = [];
 }
diff --git a/src/OrderMonitor.Infrastructure/Data/Entities/OrderProductTrackingEntity.cs b/src/OrderMonitor.Infrastructure/Data/Entities/OrderProductTrackingEntity.cs
@@ -27,7 +27,7 @@ public class OrderProductTrackingEntity
     public bool IsPrimaryComponent { get; set; }
 
     [Column("TPartnerCode")]
-    public int? TPartnerCode { get; set; }
+    public int TPartnerCode { get; set; }
 
     [Column("OPT_SnSpId")]
     public int? OptSnSpId { get; set; }
diff --git a/src/OrderMonitor.Infrastructure/DependencyInjection.cs b/src/OrderMonitor.Infrastructure/DependencyInjection.cs
@@ -1,5 +1,6 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;
 using OrderMonitor.Core.Configuration;
 using OrderMonitor.Core.Interfaces;
 using OrderMonitor.Core.Services;
@@ -25,10 +26,10 @@ public static IServiceCollection AddInfrastructure(
         services.AddDbContext<OrderMonitorDbContext>((sp, options) =>
         {
             var config = sp.GetRequiredService<IConfiguration>();
+            var logger = sp.GetRequiredService<ILoggerFactory>().CreateLogger("DatabaseSetup");
 
-            // Resolve database provider
-            var providerString = config["Database:Provider"] ?? "SqlServer";
-            var provider = DatabaseProviderFactory.ParseProvider(providerString);
+            // Resolve database provider from connection enable flags
+            var provider = ResolveProviderFromConnectionFlags(config, logger);
 
             // Resolve connection string
             var connectionString = config["Database:ConnectionString"];
@@ -73,4 +74,87 @@ public static IServiceCollection AddInfrastructure(
 
         return services;
     }
+
+    /// <summary>
+    /// Resolves the database provider from connection enable flags.
+    /// Checks environment variables first (SQL_CONNECTIONENABLE, MYSQL_CONNECTIONENABLE, POSTGRES_CONNECTIONENABLE),
+    /// then falls back to configuration section (DatabaseConnections:SqlConnectionEnable, etc.),
+    /// then falls back to Database:Provider setting.
+    /// </summary>
+    private static DatabaseProvider ResolveProviderFromConnectionFlags(
+        IConfiguration config,
+        ILogger logger)
+    {
+        // Check environment variables first, then configuration section
+        var sqlEnabled = GetConnectionFlag("SQL_CONNECTIONENABLE", "DatabaseConnections:SqlConnectionEnable", config);
+        var mysqlEnabled = GetConnectionFlag("MYSQL_CONNECTIONENABLE", "DatabaseConnections:MySqlConnectionEnable", config);
+        var postgresEnabled = GetConnectionFlag("POSTGRES_CONNECTIONENABLE", "DatabaseConnections:PostgresConnectionEnable", config);
+
+        // If no connection flags are set at all, fall back to Database:Provider
+        if (sqlEnabled is null && mysqlEnabled is null && postgresEnabled is null)
+        {
+            var providerString = config["Database:Provider"] ?? "SqlServer";
+            logger.LogInformation("No connection enable flags found. Falling back to Database:Provider = {Provider}", providerString);
+            return DatabaseProviderFactory.ParseProvider(providerString);
+        }
+
+        // Default unset flags to false
+        var sql = sqlEnabled ?? false;
+        var mysql = mysqlEnabled ?? false;
+        var postgres = postgresEnabled ?? false;
+
+        var enabledCount = (sql ? 1 : 0) + (mysql ? 1 : 0) + (postgres ? 1 : 0);
+
+        if (enabledCount == 0)
+        {
+            throw new InvalidOperationException(
+                "No database connection is enabled. " +
+                "Set one of: SQL_CONNECTIONENABLE=true, MYSQL_CONNECTIONENABLE=true, or POSTGRES_CONNECTIONENABLE=true.");
+        }
+
+        if (enabledCount > 1)
+        {
+            throw new InvalidOperationException(
+                "Multiple database connections are enabled. Only one can be active at a time. " +
+                $"Current: SQL={sql}, MySQL={mysql}, PostgreSQL={postgres}.");
+        }
+
+        if (sql)
+        {
+            logger.LogInformation("Database connection: SQL Server enabled");
+            return DatabaseProvider.SqlServer;
+        }
+
+        if (mysql)
+        {
+            logger.LogInformation("Database connection: MySQL enabled");
+            return DatabaseProvider.MySql;
+        }
+
+        logger.LogInformation("Database connection: PostgreSQL enabled");
+        return DatabaseProvider.PostgreSql;
+    }
+
+    /// <summary>
+    /// Gets a connection enable flag value. Checks environment variable first, then configuration.
+    /// Returns null if neither is set.
+    /// </summary>
+    private static bool? GetConnectionFlag(string envVarName, string configKey, IConfiguration config)
+    {
+        // Check environment variable first
+        var envValue = Environment.GetEnvironmentVariable(envVarName);
+        if (!string.IsNullOrWhiteSpace(envValue))
+        {
+            return string.Equals(envValue.Trim(), "true", StringComparison.OrdinalIgnoreCase);
+        }
+
+        // Fall back to configuration section
+        var configValue = config[configKey];
+        if (!string.IsNullOrWhiteSpace(configValue))
+        {
+            return string.Equals(configValue.Trim(), "true", StringComparison.OrdinalIgnoreCase);
+        }
+
+        return null;
+    }
 }
diff --git a/tests/OrderMonitor.IntegrationTests/Providers/DatabaseProviderTestBase.cs b/tests/OrderMonitor.IntegrationTests/Providers/DatabaseProviderTestBase.cs
@@ -72,10 +72,10 @@ private async Task SeedTestDataAsync()
 
         // Orders
         DbContext.ConsolidationOrders.AddRange(
-            new ConsolidationOrderEntity { CONumber = "CO001", OrderNumber = "ORD001", WebsiteCode = "US" },
-            new ConsolidationOrderEntity { CONumber = "CO002", OrderNumber = "ORD002", WebsiteCode = "UK" },
-            new ConsolidationOrderEntity { CONumber = "CO003", OrderNumber = "ORD003", WebsiteCode = "DE" },
-            new ConsolidationOrderEntity { CONumber = "CO004", OrderNumber = "ORD004", WebsiteCode = "US" }
+            new ConsolidationOrderEntity { CONumber = "CO001", OrderNumber = "ORD001", WebsiteCode = 1 },
+            new ConsolidationOrderEntity { CONumber = "CO002", OrderNumber = "ORD002", WebsiteCode = 2 },
+            new ConsolidationOrderEntity { CONumber = "CO003", OrderNumber = "ORD003", WebsiteCode = 3 },
+            new ConsolidationOrderEntity { CONumber = "CO004", OrderNumber = "ORD004", WebsiteCode = 1 }
         );
 
         // Stuck prep order (>6h at status 3050)
@@ -164,7 +164,7 @@ public async Task GetStuckOrders_IncludesRelatedData()
         order.OrderNumber.Should().Be("ORD001");
         order.Status.Should().Be("PreparationStarted");
         order.ProductType.Should().Be("Photo Book");
-        order.Region.Should().Be("US");
+        order.Region.Should().Be("1");
         order.FacilityName.Should().Be("Facility Alpha");
     }
 
diff --git a/tests/OrderMonitor.IntegrationTests/Providers/QueryPerformanceTests.cs b/tests/OrderMonitor.IntegrationTests/Providers/QueryPerformanceTests.cs
@@ -98,7 +98,7 @@ private async Task SeedPerformanceDataAsync()
         var statusIds = new[] { 3050, 3060, 4001, 4200, 6400 };
         var specIds = new[] { 100, 200, 300, 400 };
         var partnerIds = new[] { 10, 20 };
-        var websites = new[] { "US", "UK", "DE", "FR", "AU" };
+        var websites = new[] { 1, 2, 3, 4, 5 };
         var random = new Random(42); // deterministic
 
         long optId = 1;
diff --git a/tests/OrderMonitor.UnitTests/Data/EfCoreOrderRepositoryTests.cs b/tests/OrderMonitor.UnitTests/Data/EfCoreOrderRepositoryTests.cs
@@ -55,10 +55,10 @@ private void SeedTestData()
 
         // Orders
         _dbContext.ConsolidationOrders.AddRange(
-            new ConsolidationOrderEntity { CONumber = "CO001", OrderNumber = "ORD001", WebsiteCode = "US" },
-            new ConsolidationOrderEntity { CONumber = "CO002", OrderNumber = "ORD002", WebsiteCode = "UK" },
-            new ConsolidationOrderEntity { CONumber = "CO003", OrderNumber = "ORD003", WebsiteCode = "DE" },
-            new ConsolidationOrderEntity { CONumber = "CO004", OrderNumber = "ORD004", WebsiteCode = "US" }
+            new ConsolidationOrderEntity { CONumber = "CO001", OrderNumber = "ORD001", WebsiteCode = 1 },
+            new ConsolidationOrderEntity { CONumber = "CO002", OrderNumber = "ORD002", WebsiteCode = 2 },
+            new ConsolidationOrderEntity { CONumber = "CO003", OrderNumber = "ORD003", WebsiteCode = 3 },
+            new ConsolidationOrderEntity { CONumber = "CO004", OrderNumber = "ORD004", WebsiteCode = 1 }
         );
 
         // Order product trackings - stuck prep order (>6h at status 3050)
@@ -161,7 +161,7 @@ public async Task GetStuckOrdersAsync_IncludesRelatedData()
         order.OrderNumber.Should().Be("ORD001");
         order.Status.Should().Be("PreparationStarted");
         order.ProductType.Should().Be("Photo Book");
-        order.Region.Should().Be("US");
+        order.Region.Should().Be("1");
         order.FacilityName.Should().Be("Facility Alpha");
     }
 
diff --git a/tests/OrderMonitor.UnitTests/Data/EntityModelTests.cs b/tests/OrderMonitor.UnitTests/Data/EntityModelTests.cs
@@ -11,7 +11,7 @@ public void ConsolidationOrderEntity_DefaultValues()
         var entity = new ConsolidationOrderEntity();
         entity.CONumber.Should().Be(string.Empty);
         entity.OrderNumber.Should().BeNull();
-        entity.WebsiteCode.Should().BeNull();
+        entity.WebsiteCode.Should().Be(0);
         entity.OrderProductTrackings.Should().BeEmpty();
     }
 
@@ -24,7 +24,7 @@ public void OrderProductTrackingEntity_DefaultValues()
         entity.Status.Should().Be(0);
         entity.LastUpdatedDate.Should().BeNull();
         entity.IsPrimaryComponent.Should().BeFalse();
-        entity.TPartnerCode.Should().BeNull();
+        entity.TPartnerCode.Should().Be(0);
         entity.OptSnSpId.Should().BeNull();
         entity.OrderDate.Should().BeNull();
     }
@@ -70,12 +70,12 @@ public void ConsolidationOrderEntity_CanSetProperties()
         {
             CONumber = "CO12345",
             OrderNumber = "12345",
-            WebsiteCode = "US"
+            WebsiteCode = 1
         };
 
         entity.CONumber.Should().Be("CO12345");
         entity.OrderNumber.Should().Be("12345");
-        entity.WebsiteCode.Should().Be("US");
+        entity.WebsiteCode.Should().Be(1);
     }
 
     [Fact]
diff --git a/tests/OrderMonitor.UnitTests/Data/OrderMonitorDbContextTests.cs b/tests/OrderMonitor.UnitTests/Data/OrderMonitorDbContextTests.cs
@@ -42,7 +42,7 @@ public async Task CanInsertAndRetrieveConsolidationOrder()
         {
             CONumber = "CO12345",
             OrderNumber = "12345",
-            WebsiteCode = "US"
+            WebsiteCode = 1
         };
 
         _dbContext.ConsolidationOrders.Add(order);
@@ -51,7 +51,7 @@ public async Task CanInsertAndRetrieveConsolidationOrder()
         var retrieved = await _dbContext.ConsolidationOrders.FindAsync("CO12345");
         retrieved.Should().NotBeNull();
         retrieved!.OrderNumber.Should().Be("12345");
-        retrieved.WebsiteCode.Should().Be("US");
+        retrieved.WebsiteCode.Should().Be(1);
     }
 
     [Fact]

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,7 @@ public class ConsolidationOrderEntity`
`19`	`19`	`public string? OrderNumber { get; set; }`
`20`	`20`
`21`	`21`	`[Column("websiteCode")]`
`22`		`- [StringLength(20)]`
`23`		`- public string? WebsiteCode { get; set; }`
	`22`	`+ public int WebsiteCode { get; set; }`
`24`	`23`
`25`	`24`	`public ICollection<OrderProductTrackingEntity> OrderProductTrackings { get; set; } = [];`
`26`	`25`	`}`