Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Code Review
This pull request introduces a get_inference_config method to both the classifier and regressor, allowing users to access the active configuration before calling fit. It also cleans up the codebase by removing unused V2.6 preprocessor configurations and presets. The review feedback recommends returning a deep copy of the configuration object to prevent accidental mutation of the estimator's internal state and suggests standardizing docstring formatting for better consistency across the documentation.
There was a problem hiding this comment.
Sorry,
I think I previously overlooked something. Can't we now remove _get_tabpfn_v2_6_config: https://github.com/PriorLabs/TabPFN/blob/231de0c/src/tabpfn/inference_config.py#L332-L364?
|
Yep, should be removed with this PR? |
oscarkey
left a comment
There was a problem hiding this comment.
lgtm!
Maybe a unit test for each? 😇
No description provided.