Skip to content

Introduces API to get inference config, removes unused inference config defaults#890

Merged
bejaeger merged 5 commits intomainfrom
ben/remove-unused-inference-config-defaults
Apr 24, 2026
Merged

Introduces API to get inference config, removes unused inference config defaults#890
bejaeger merged 5 commits intomainfrom
ben/remove-unused-inference-config-defaults

Conversation

@bejaeger
Copy link
Copy Markdown
Collaborator

@bejaeger bejaeger commented Apr 23, 2026

No description provided.

@bejaeger
Copy link
Copy Markdown
Collaborator Author

This change is part of the following stack:

Change managed by git-spice.

@bejaeger bejaeger requested a review from a team as a code owner April 23, 2026 10:10
@bejaeger bejaeger requested review from priorphil and removed request for a team April 23, 2026 10:10
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@bejaeger bejaeger removed the request for review from priorphil April 23, 2026 10:15
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a get_inference_config method to both the classifier and regressor, allowing users to access the active configuration before calling fit. It also cleans up the codebase by removing unused V2.6 preprocessor configurations and presets. The review feedback recommends returning a deep copy of the configuration object to prevent accidental mutation of the estimator's internal state and suggests standardizing docstring formatting for better consistency across the documentation.

Comment thread src/tabpfn/classifier.py Outdated
Comment thread src/tabpfn/regressor.py Outdated
Comment thread src/tabpfn/regressor.py Outdated
Copy link
Copy Markdown
Contributor

@adrian-prior adrian-prior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrian-prior adrian-prior self-requested a review April 23, 2026 22:52
Copy link
Copy Markdown
Contributor

@adrian-prior adrian-prior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry,
I think I previously overlooked something. Can't we now remove _get_tabpfn_v2_6_config: https://github.com/PriorLabs/TabPFN/blob/231de0c/src/tabpfn/inference_config.py#L332-L364?

@bejaeger
Copy link
Copy Markdown
Collaborator Author

Yep, should be removed with this PR?

Copy link
Copy Markdown
Contributor

@oscarkey oscarkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Maybe a unit test for each? 😇

@bejaeger bejaeger enabled auto-merge April 24, 2026 12:28
@bejaeger bejaeger added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 0dff55b Apr 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants