Skip to content

Bust GCP Cloud Storage cache#30

Merged
safaricd merged 2 commits into
mainfrom
bust-cs-cache
Sep 25, 2025
Merged

Bust GCP Cloud Storage cache#30
safaricd merged 2 commits into
mainfrom
bust-cs-cache

Conversation

@safaricd
Copy link
Copy Markdown
Collaborator

Change Description

  • Whenever the config/telemetry.json file changes, we want to detect these changes ASAP, without relying on default cache policy and TTLs.

This change allows us to bust the cache by passing an additional and irrelevant query string parameter.

@safaricd safaricd requested a review from simo-prior September 18, 2025 22:19
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mechanism to bypass caching for the config/telemetry.json file hosted on GCP Cloud Storage. By adding a dynamic timestamp as a query parameter to the request URL, the system will always fetch the most current version of the telemetry configuration, preventing issues caused by stale cached data and ensuring immediate propagation of configuration changes.

Highlights

  • Cache Busting Mechanism: Implemented a cache-busting strategy for the config/telemetry.json file by appending a unique timestamp query parameter to the request URL, ensuring the latest configuration is always fetched.
  • Dependency Update: Added an import for timezone from the datetime module to facilitate the generation of UTC timestamps for cache busting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a cache-busting mechanism for fetching the telemetry configuration file by adding a timestamp as a query parameter. This is a good strategy to ensure that stale versions are not served from GCP Cloud Storage's cache. My review includes one comment highlighting a potential issue where an existing in-memory cache might delay the propagation of configuration changes, which could be contrary to the goal of detecting changes 'ASAP'.

Comment thread src/tabpfn_common_utils/telemetry/core/service.py Outdated
@safaricd safaricd merged commit 8bfc657 into main Sep 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants