Add ping frequency#36
Conversation
Summary of ChangesHello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the telemetry system by introducing the concept of ping frequency. By adding a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a frequency attribute to the PingEvent to track daily, weekly, and monthly active users. The changes include updating the PingEvent data class, the ping flow to handle different frequencies, and corresponding tests. While the idea is good, there's a critical issue in the implementation of the ping flow in src/tabpfn_common_utils/telemetry/interactive/flows.py. The current logic will prevent weekly and monthly pings from being sent correctly, and all pings would be incorrectly reported with a "daily" frequency. I've left a detailed comment with a suggested fix. Additionally, I recommend adding unit tests for the new logic in the ping function to prevent such issues in the future.
brendan-priorlabs
left a comment
There was a problem hiding this comment.
LGTM after that continue!
Change Description
frequencytoPingEvent, allowing to gather insights on weekly and monthly active users.