Skip to content

Add ping frequency#36

Merged
safaricd merged 5 commits into
mainfrom
add-ping-frequency
Sep 24, 2025
Merged

Add ping frequency#36
safaricd merged 5 commits into
mainfrom
add-ping-frequency

Conversation

@safaricd
Copy link
Copy Markdown
Collaborator

Change Description

  • Add frequency to PingEvent, allowing to gather insights on weekly and monthly active users.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the telemetry system by introducing the concept of ping frequency. By adding a frequency attribute to PingEvent and updating the ping logic, the system can now gather more granular insights into user activity, specifically enabling the tracking of weekly and monthly active users in addition to daily. This change provides a more comprehensive understanding of usage patterns without disrupting existing daily ping mechanisms.

Highlights

  • Enhanced Ping Event: The PingEvent now includes a frequency attribute, allowing pings to be categorized as daily, weekly, or monthly.
  • Flexible Ping Scheduling: The telemetry system has been updated to support sending pings at different frequencies (daily, weekly, monthly) and tracking the last ping time for each frequency independently.
  • Backward Compatibility: The ping logic includes backward compatibility to ensure existing daily ping tracking is maintained when transitioning to the new frequency-based system.
  • Version Update: The project version has been incremented from 0.2.0 to 0.2.2 to reflect these changes, and the changelog has been updated accordingly.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a frequency attribute to the PingEvent to track daily, weekly, and monthly active users. The changes include updating the PingEvent data class, the ping flow to handle different frequencies, and corresponding tests. While the idea is good, there's a critical issue in the implementation of the ping flow in src/tabpfn_common_utils/telemetry/interactive/flows.py. The current logic will prevent weekly and monthly pings from being sent correctly, and all pings would be incorrectly reported with a "daily" frequency. I've left a detailed comment with a suggested fix. Additionally, I recommend adding unit tests for the new logic in the ping function to prevent such issues in the future.

Comment thread src/tabpfn_common_utils/telemetry/interactive/flows.py
Copy link
Copy Markdown
Contributor

@brendan-priorlabs brendan-priorlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after that continue!

Comment thread src/tabpfn_common_utils/telemetry/interactive/flows.py Outdated
@safaricd safaricd merged commit 473352e into main Sep 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants