[ENG-187] Change behaviour for opt_in

[safaricd]

Change Description

• Don't prompt for opt_in under 24 hours since install
• Don't prompt if number of usages below 5
• Refactored ProductTelemetry and moved download_config to telemetry/config.py to make it more easily accessible to other functions.

[gemini-code-assist]

Summary of Changes

Hello @safaricd, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the opt_in prompt mechanism to improve user experience and engagement. By introducing a delay for new installations and a minimum usage threshold, the system intelligently postpones opt_in requests. This approach aims to prevent premature prompting of new or infrequent users, thereby reducing potential friction and ensuring that the prompt is presented to a more relevant and active user base.

Highlights

• Delayed Opt-In Prompt for New Installations: The system will now prevent opt_in prompts immediately after a new installation, ensuring a smoother initial user experience.
• 24-Hour Post-Installation Grace Period: Users will not be prompted for opt_in within the first 24 hours following the application's installation.
• Usage-Based Opt-In Threshold: An opt_in prompt will only appear after the application has been used more than 5 times, targeting more active and engaged users.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a delay for the opt_in prompt, conditioning it on the time since installation and the number of usages. The implementation is a good step towards targeting more active users. However, I've identified a logic error in the usage count check that causes the prompt to appear later than intended. Additionally, there are opportunities to improve code quality by replacing magic numbers with named constants and optimizing a file I/O pattern that is currently inefficient.

[noahho]

LGTM