Skip to content

[ENG-259]#41

Merged
safaricd merged 4 commits into
mainfrom
ENG-259
Nov 4, 2025
Merged

[ENG-259]#41
safaricd merged 4 commits into
mainfrom
ENG-259

Conversation

@safaricd
Copy link
Copy Markdown
Collaborator

Change Description

No telemetry events were recorded for TabPFN-TS using the TabPFN API client library. This is because the decorators were expecting tabpfn to run, however tabpfn is never used then.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing telemetry events from being recorded for TabPFN-TS models by enhancing the task inference mechanism to correctly recognize time series regression. The change ensures that usage data for these models is accurately captured, which is vital for monitoring and analysis. Additionally, the project version has been updated, and a minor cleanup was performed in the interactive prompt handling.

Highlights

  • Telemetry Fix for TabPFN-TS: Resolved an issue where telemetry events were not being recorded for TabPFN-TS models because the decorator logic failed to correctly identify tabpfn_time_series as a regression task.
  • Version Update: The project version has been incremented from 0.2.2 to 0.2.4 in pyproject.toml.
  • Changelog Entry: A new entry has been added to CHANGELOG.md documenting the telemetry fix for TabPFN-TS.
  • Minor Code Cleanup: A redundant print(on_retry_message) statement was removed from the interactive prompt parsing logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses an issue where telemetry events were not being recorded for TabPFN-TS when using the TabPFN API client library. The changes include updating the version number in pyproject.toml and CHANGELOG.md, adding a condition to infer the task for tabpfn_time_series in decorators.py, and removing an unnecessary print statement in base.py. The review focuses on the correctness of the added condition and the removal of the print statement.

Comment on lines +478 to +479
if m.startswith("tabpfn_time_series"):
return "regression"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change introduces a new condition to infer the task for tabpfn_time_series. It's high severity because it directly impacts the telemetry data being collected, and any inaccuracies here would lead to incorrect data analysis. It's important to ensure that this condition accurately reflects the task type for time series models.

Comment thread src/tabpfn_common_utils/telemetry/interactive/prompts/base.py
@safaricd safaricd merged commit 3c3fcb3 into main Nov 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants