Fix issue with telemetry not being sent through#44
Conversation
Summary of ChangesHello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug that prevented telemetry events from being sent by removing an erroneous test environment detection mechanism. The change simplifies the telemetry service by eliminating unnecessary logic and its corresponding test file, ensuring that telemetry data is now correctly captured. The project version has also been updated to reflect this important fix. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a critical bug that prevented telemetry events from being sent. The root cause was a brittle test environment detection mechanism (_runs_in_test) that incorrectly disabled telemetry in some production scenarios. The fix involves removing this method and its associated tests entirely, which is a sound approach to resolve the issue. The system now relies on environment variables and CI detection, which is more robust. The versioning and changelog have been updated accordingly. I have one minor suggestion for the changelog entry to improve its clarity.
| ## [0.2.6] - 2025-11-06 | ||
|
|
||
| ### Changed | ||
| - Fix an issue because of which telemetry events were not sent. |
There was a problem hiding this comment.
Change Description