Skip to content

Fix issue with telemetry not being sent through#44

Merged
safaricd merged 1 commit into
mainfrom
fix-telemetry-not-sent
Nov 6, 2025
Merged

Fix issue with telemetry not being sent through#44
safaricd merged 1 commit into
mainfrom
fix-telemetry-not-sent

Conversation

@safaricd
Copy link
Copy Markdown
Collaborator

@safaricd safaricd commented Nov 6, 2025

Change Description

  • Fix an issue because telemetry events were not sent ❗

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that prevented telemetry events from being sent by removing an erroneous test environment detection mechanism. The change simplifies the telemetry service by eliminating unnecessary logic and its corresponding test file, ensuring that telemetry data is now correctly captured. The project version has also been updated to reflect this important fix.

Highlights

  • Telemetry Fix: Resolved an issue where telemetry events were not being sent due to faulty test environment detection logic.
  • Code Simplification: Removed the _runs_in_test method and associated imports (sys, functools.lru_cache) from the telemetry service, simplifying the codebase.
  • Test File Removal: Deleted the tests/telemetry/core/test_service.py file, as its purpose was to test the now-removed _runs_in_test method.
  • Version Update: Incremented the project version from 0.2.5 to 0.2.6 in pyproject.toml and uv.lock.
  • Changelog Update: Added a new entry to CHANGELOG.md for version 0.2.6, documenting the telemetry fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a critical bug that prevented telemetry events from being sent. The root cause was a brittle test environment detection mechanism (_runs_in_test) that incorrectly disabled telemetry in some production scenarios. The fix involves removing this method and its associated tests entirely, which is a sound approach to resolve the issue. The system now relies on environment variables and CI detection, which is more robust. The versioning and changelog have been updated accordingly. I have one minor suggestion for the changelog entry to improve its clarity.

Comment thread CHANGELOG.md
## [0.2.6] - 2025-11-06

### Changed
- Fix an issue because of which telemetry events were not sent.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better clarity and more standard phrasing, consider rewording this changelog entry. The suggested phrasing is more direct about the nature of the fix.

Suggested change
- Fix an issue because of which telemetry events were not sent.
- Fix an issue that prevented telemetry events from being sent.

@safaricd safaricd merged commit 296e5d8 into main Nov 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants