test(Maui): wire navigation recorder into container mock

Assign PageNavigationContainerMock.SharedNavigationRecorder from
PageNavigationServiceMock so DI-resolved pages record lifecycle events.

Update NavigateAsync_From_NavigationPage_When_NotClearNavigationStack_And_SamePage
to assert the Prism re-navigation sequence on the existing top page; the prior
recorder.IsEmpty check passed only because resolved pages had no recorder.

Author: dansiegel

tests/Maui/Prism.Maui.Tests/Fixtures/PageNavigationServiceFixture.cs

@@ -744,7 +744,7 @@ public async Task NavigateAsync_From_NavigationPage_With_ChildPage_And_DoesNotRe
         [Fact]
         public async Task NavigateAsync_From_NavigationPage_When_NotClearNavigationStack_And_SamePage()
         {
-            var recorder = new PageNavigationEventRecorder(); ;
+            var recorder = new PageNavigationEventRecorder();
             var navigationService = new PageNavigationServiceMock(_container, _app, recorder);
             var contentPageMock = new ContentPageMock(recorder);
             var navigationPage = new NavigationPageMock(recorder, contentPageMock);
@@ -755,6 +755,7 @@ public async Task NavigateAsync_From_NavigationPage_When_NotClearNavigationStack
             Assert.True(r1.Success);
 
             var secondContentPage = navigationPage.Navigation.NavigationStack.Last();
+            var secondVm = Assert.IsType<SecondContentPageMockViewModel>(secondContentPage.BindingContext);
 
             recorder.Clear();
             ((IPageAware)navigationService).Page = navigationPage;
@@ -765,7 +766,18 @@ public async Task NavigateAsync_From_NavigationPage_When_NotClearNavigationStack
             Assert.Empty(navigationPage.Navigation.ModalStack);
             Assert.Equal(2, navigationPage.Navigation.NavigationStack.Count);
             Assert.Same(secondContentPage, navigationPage.Navigation.NavigationStack.Last());
-            Assert.True(recorder.IsEmpty);
+
+            // DoNavigateAction still runs Initialize + NavigatedFrom/To on the existing top page (see PageNavigationService.ProcessNavigationForNavigationPage).
+            // Previously this asserted recorder.IsEmpty because DI-created pages had no recorder wired; that hid real lifecycle callbacks.
+            AssertPageNavigationRecords(recorder.Records,
+                (secondContentPage, PageNavigationEvent.OnInitialized),
+                (secondVm, PageNavigationEvent.OnInitialized),
+                (secondContentPage, PageNavigationEvent.OnInitializedAsync),
+                (secondVm, PageNavigationEvent.OnInitializedAsync),
+                (secondContentPage, PageNavigationEvent.OnNavigatedFrom),
+                (secondVm, PageNavigationEvent.OnNavigatedFrom),
+                (secondContentPage, PageNavigationEvent.OnNavigatedTo),
+                (secondVm, PageNavigationEvent.OnNavigatedTo));
         }
 
 

tests/Maui/Prism.Maui.Tests/Mocks/PageNavigationServiceMock.cs

@@ -11,7 +11,9 @@ public sealed class PageNavigationServiceMock : PageNavigationService, IPageAwar
     public PageNavigationServiceMock(PageNavigationContainerMock container, ApplicationMock app, PageNavigationEventRecorder? recorder = null)
         : base(container, new TestWindowManager(app.Window), new EventAggregator(), new MutablePageAccessor())
     {
-        _ = recorder;
+        // Wire recorder into DI-resolved pages (ContentPageMock, etc.) via PageNavigationContainerMock.AfterResolve.
+        // Always assign so a shared fixture container does not keep a stale recorder when the next test omits it.
+        container.SharedNavigationRecorder = recorder;
     }
 
     Page IPageAware.Page