Adopts Central Package Management and Enables SBOM#3398
Merged
Conversation
Migrates package references to `GlobalPackageReference` for centralized version management via `Directory.Packages.props`. This also enables Software Bill of Materials (SBOM) generation for packable projects, enhancing supply chain security.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14ccbd5a63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This update ensures that generated Software Bill of Materials (SBOMs) include detailed company and copyright information. It also explicitly sets the package version for SBOMs and enables fetching license information, improving accuracy and supply chain security.
Updates the condition for `ContinuousIntegrationBuild` to specifically check for `GITHUB_ACTIONS` or the generic `CI` environment variable. This ensures more reliable detection of continuous integration environments, particularly for GitHub Actions and other common CI hosts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This change updates the project's build system to adopt Central Package Management (CPM) for global, build-time only dependencies. Existing
PackageReferenceitems for tools likeMicrosoft.NETFramework.ReferenceAssemblies,Nerdbank.GitVersioning, andMicrosoft.SourceLink.GitHubare migrated toGlobalPackageReference, centralizing their version management inDirectory.Packages.props.Additionally, Software Bill of Material (SBOM) generation is enabled for all packable projects. This is achieved by incorporating the
Microsoft.Sbom.Targetspackage and setting theGenerateSBOMproperty totrue.Bugs Fixed
API Changes
None
Behavioral Changes
Packable projects will now automatically generate an SBOM during the build process, which will be included in the build output. This is a change to the build system and does not affect the runtime behavior of applications.
PR Checklist