bedrock: fix BiomeChunkGeneration structure for 1.26.20+ (proto 970+)#1205
Open
killcerr wants to merge 1 commit into
Open
bedrock: fix BiomeChunkGeneration structure for 1.26.20+ (proto 970+)#1205killcerr wants to merge 1 commit into
killcerr wants to merge 1 commit into
Conversation
Update BiomeChunkGeneration to match the official protocol documentation for protocol version 970+. Surface-related fields (surface_materials, has_default_overworld_surface, has_swamp_surface, has_frozen_ocean_surface, has_end_surface, mesa_surface, capped_surface) have been moved into a new BiomeSurfaceBuilderData container type, and two new optional fields (surface_builder_data, subsurface_builder_data) have been added. Also adds the new BiomeNoiseGradientSurfaceData type referenced by BiomeSurfaceBuilderData. This fixes parsing of biome_definition_list (0x7a) packets which caused 'Server packet parse error' in bedrock-protocol relay mode.
Member
|
Thanks, does this apply to any older versions or only 1.26.20+ ? |
Author
I only confirmed the fix for 1.26.20+ (proto 970+). I haven’t had time to check older versions, and I also haven’t looked into exactly which protocol version the change was introduced. So I can’t say for sure whether it affects any earlier versions or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update BiomeChunkGeneration to match the official protocol documentation for protocol version 970+. Surface-related fields (surface_materials, has_default_overworld_surface, has_swamp_surface, has_frozen_ocean_surface, has_end_surface, mesa_surface, capped_surface) have been moved into a new BiomeSurfaceBuilderData container type, and two new optional fields (surface_builder_data, subsurface_builder_data) have been added.
Also adds the new BiomeNoiseGradientSurfaceData type referenced by BiomeSurfaceBuilderData.
This fixes parsing of biome_definition_list (0x7a) packets which caused
'Server packet parse error' in bedrock-protocol relay mode.